From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752101AbbCWDEQ (ORCPT ); Sun, 22 Mar 2015 23:04:16 -0400 Received: from mail-bl2on0081.outbound.protection.outlook.com ([65.55.169.81]:34640 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752051AbbCWDEL (ORCPT ); Sun, 22 Mar 2015 23:04:11 -0400 Message-ID: <550F8297.80809@opensource.altera.com> Date: Sun, 22 Mar 2015 22:03:51 -0500 From: Dinh Nguyen User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Walter Lozano CC: Rob Herring , Pawel Moll , "Mark Rutland" , Ian Campbell , Kumar Gala , , "devicetree@vger.kernel.org" , , "linux-kernel@vger.kernel.org" , "Steffen Trumtrar" Subject: Re: [PATCH v2] ARM: socfpga: dts: Add adxl34x References: <1419462712-14151-1-git-send-email-walter@vanguardiasur.com.ar> <20150105092153.GJ13070@pengutronix.de> In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [99.103.66.154] X-ClientProxiedBy: BN3PR11CA0028.namprd11.prod.outlook.com (25.162.169.38) To CY1PR03MB1374.namprd03.prod.outlook.com (25.163.16.28) Authentication-Results: pengutronix.de; dkim=none (message not signed) header.d=none;pengutronix.de; dkim=none (message not signed) header.d=none; X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR03MB1374;UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CH1PR03MB612; X-Forefront-Antispam-Report-Untrusted: BMV:1;SFV:NSPM;SFS:(10009020)(6009001)(51704005)(479174004)(377454003)(66066001)(19580395003)(19580405001)(23676002)(46102003)(87976001)(50986999)(47776003)(86362001)(2950100001)(65806001)(65956001)(40100003)(42186005)(76176999)(122386002)(50466002)(77156002)(54356999)(33656002)(110136001)(83506001)(65816999)(92566002)(62966003);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR03MB1374;H:Dinhs-MacBook-Pro.local;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:;UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5002010)(5005006);SRVR:CY1PR03MB1374;BCL:0;PCL:0;RULEID:;SRVR:CY1PR03MB1374;BCL:0;PCL:0;RULEID:(601004)(5005006)(5002010);SRVR:CH1PR03MB612;BCL:0;PCL:0;RULEID:;SRVR:CH1PR03MB612; X-Forefront-PRVS: 05245CA661 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR03MB1374 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: BL2FFO11FD008.protection.gbl Authentication-Results: spf=fail (sender IP is 66.35.236.227) smtp.mailfrom=dinguyen@opensource.altera.com; X-Forefront-Antispam-Report: CIP:66.35.236.227;CTRY:US;IPV:NLI;EFV:NLI;BMV:1;SFV:NSPM;SFS:(10009020)(6009001)(339900001)(51704005)(377454003)(479174004)(189002)(24454002)(199003)(105606002)(93886004)(65816999)(83506001)(86362001)(85426001)(23676002)(62966003)(77156002)(50466002)(54356999)(76176999)(6806004)(16796002)(19580395003)(19580405001)(87936001)(110136001)(47776003)(92566002)(66066001)(64126003)(106466001)(50986999)(122386002)(65956001)(46102003)(40100003)(65806001)(33656002)(2950100001)(7099025);DIR:OUT;SFP:1101;SCL:1;SRVR:CH1PR03MB612;H:sj-itexedge03.altera.priv.altera.com;FPR:;SPF:Fail;MLV:ovrnspm;MX:1;A:0;PTR:InfoDomainNonexistent;LANG:en; X-Forefront-PRVS: 05245CA661 X-OriginatorOrg: opensource.altera.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2015 03:04:05.8159 (UTC) X-MS-Exchange-CrossTenant-Id: fbd72e03-d4a5-4110-adce-614d51f2077a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fbd72e03-d4a5-4110-adce-614d51f2077a;Ip=[66.35.236.227];Helo=[sj-itexedge03.altera.priv.altera.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH1PR03MB612 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Walter, On 3/19/15 4:27 PM, Walter Lozano wrote: > Hi Dinh, > > On Mon, Mar 16, 2015 at 10:10 AM, Walter Lozano > wrote: >> On Mon, Jan 5, 2015 at 6:21 AM, Steffen Trumtrar >> wrote: >>> Hi! >>> >>> On Wed, Dec 24, 2014 at 08:11:52PM -0300, Walter Lozano wrote: >>>> This patch adds the DTS bindings for the adxl34x digital >>>> accelerometer. >>>> >>>> Signed-off-by: Walter Lozano >>>> --- >>>> arch/arm/boot/dts/socfpga_cyclone5_sockit.dts | 16 ++++++++++++++++ >>>> 1 file changed, 16 insertions(+) >>>> >>>> diff --git a/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts b/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts >>>> index 16ea6f5..d343e03 100644 >>>> --- a/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts >>>> +++ b/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts >>>> @@ -60,6 +60,22 @@ >>>> rxc-skew-ps = <2000>; >>>> }; >>>> >>>> +&gpio2 { >>>> + status = "okay"; >>>> +}; >>>> + >>>> +&i2c1 { >>>> + status = "okay"; >>>> + >>>> + accel1: accelerometer@53 { >>>> + compatible = "adxl34x"; Shouldn't this be "adi,adxl34x"? At least that's what the documentation says. >>>> + reg = <0x53>; >>>> + >>>> + interrupt-parent = <&portc>; >>>> + interrupts = <3 2>; >>>> + }; >>>> +}; >>>> + >>>> &mmc0 { >>>> vmmc-supply = <®ulator_3_3v>; >>>> vqmmc-supply = <®ulator_3_3v>; >>> >>> I just gave it a short spin. I get some interrupts and the position property >>> changes, so it seems to work: >>> >>> Acked-by: Steffen Trumtrar >>> >> >> Ping? >> How should this continue? > > Any news about this patch? It has been acked by Pavel Machek and > Steffen Trumtrar a while ago. > Sorry, since I wasn't CC on the original patch and somehow my filter didn't catch it, I didn't see this patch until now. Dinh