From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752421AbbCWKO2 (ORCPT <rfc822;w@1wt.eu>);
	Mon, 23 Mar 2015 06:14:28 -0400
Received: from nasmtp02.atmel.com ([204.2.163.16]:14103 "EHLO
	SJOEDG01.corp.atmel.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org
	with ESMTP id S1752268AbbCWKOX (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 23 Mar 2015 06:14:23 -0400
Message-ID: <550FE779.8010703@atmel.com>
Date: Mon, 23 Mar 2015 18:14:17 +0800
From: Bo Shen <voice.shen@atmel.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: Jonathan Richardson <jonathar@broadcom.com>,
        Dmitry Torokhov <dtor@google.com>, Anatol Pomazau <anatol@google.com>
CC: Scott Branden <sbranden@broadcom.com>,
        Grant Likely <grant.likely@linaro.org>,
        Rob Herring <robh+dt@kernel.org>, Ray Jui <rjui@broadcom.com>,
        <linux-kernel@vger.kernel.org>, <linux-input@vger.kernel.org>,
        bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
        <devicetree@vger.kernel.org>, "Joe Perches" <joe@perches.com>,
        Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        "Kumar Gala" <galak@codeaurora.org>
Subject: Re: [PATCH v5 1/2] Input: touchscreen-iproc: Add Broadcom iProc touchscreen
 driver
References: <1426899446-16873-1-git-send-email-jonathar@broadcom.com> <1426899446-16873-2-git-send-email-jonathar@broadcom.com>
In-Reply-To: <1426899446-16873-2-git-send-email-jonathar@broadcom.com>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.168.5.13]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Jonathan Richardson,

On 03/21/2015 08:57 AM, Jonathan Richardson wrote:
> +static struct platform_driver iproc_ts_driver = {
> +	.probe = iproc_ts_probe,

Just a little curious, is the .remove function missing or it doesn't 
need it.

Thanks.

> +	.driver = {
> +		.name	= IPROC_TS_NAME,
> +		.of_match_table = of_match_ptr(iproc_ts_of_match),
> +	},
> +};
> +
> +module_platform_driver(iproc_ts_driver);
> +
> +MODULE_DESCRIPTION("IPROC Touchscreen driver");
> +MODULE_AUTHOR("Broadcom");
> +MODULE_LICENSE("GPL v2");

Best Regards,
Bo Shen