From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752527AbbCWOUN (ORCPT ); Mon, 23 Mar 2015 10:20:13 -0400 Received: from mail-bl2on0104.outbound.protection.outlook.com ([65.55.169.104]:37097 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752372AbbCWOUJ (ORCPT ); Mon, 23 Mar 2015 10:20:09 -0400 X-WSS-ID: 0NLO55D-08-4NH-02 X-M-MSG: Message-ID: <55102110.4040106@amd.com> Date: Mon, 23 Mar 2015 09:20:00 -0500 From: Aravind Gopalakrishnan User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Borislav Petkov CC: "Luck, Tony" , "tglx@linutronix.de" , "mingo@redhat.com" , "hpa@zytor.com" , "slaoub@gmail.com" , "luto@amacapital.net" , "x86@kernel.org" , "linux-kernel@vger.kernel.org" , "linux-edac@vger.kernel.org" Subject: Re: [PATCH V2 2/2] x86, mce, severities: Define mce_severity function pointer References: <1426869068-4155-1-git-send-email-Aravind.Gopalakrishnan@amd.com> <1426869068-4155-3-git-send-email-Aravind.Gopalakrishnan@amd.com> <3908561D78D1C84285E8C5FCA982C28F32A267D3@ORSMSX114.amr.corp.intel.com> <550CD8EE.4090504@amd.com> <20150321061042.GA27221@pd.tnic> In-Reply-To: <20150321061042.GA27221@pd.tnic> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.180.168.240] X-EOPAttributedMessage: 0 Authentication-Results: spf=none (sender IP is 165.204.84.222) smtp.mailfrom=Aravind.Gopalakrishnan@amd.com; alien8.de; dkim=none (message not signed) header.d=none; X-Forefront-Antispam-Report: CIP:165.204.84.222;CTRY:US;IPV:NLI;EFV:NLI;BMV:1;SFV:NSPM;SFS:(10019020)(6009001)(428002)(164054003)(377454003)(189002)(51704005)(24454002)(479174004)(199003)(59896002)(105586002)(117636001)(76176999)(54356999)(50986999)(23676002)(110136001)(36756003)(120886001)(46102003)(106466001)(87936001)(65956001)(50466002)(47776003)(62966003)(77156002)(2950100001)(86362001)(92566002)(65816999)(77096005)(101416001)(83506001)(62816006);DIR:OUT;SFP:1102;SCL:1;SRVR:BY2PR02MB411;H:atltwp02.amd.com;FPR:;SPF:None;MLV:sfv;MX:1;A:1;LANG:en; X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY2PR02MB411; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006)(5002010);SRVR:BY2PR02MB411;BCL:0;PCL:0;RULEID:;SRVR:BY2PR02MB411; X-Forefront-PRVS: 05245CA661 X-OriginatorOrg: amd4.onmicrosoft.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2015 14:20:04.9155 (UTC) X-MS-Exchange-CrossTenant-Id: fde4dada-be84-483f-92cc-e026cbee8e96 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fde4dada-be84-483f-92cc-e026cbee8e96;Ip=[165.204.84.222];Helo=[atltwp02.amd.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR02MB411 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/21/2015 1:10 AM, Borislav Petkov wrote: > On Fri, Mar 20, 2015 at 09:35:26PM -0500, Aravind Gopalakrishnan wrote: >> Other function pointers in the mce code like unexpected_machine_check >> and default_threshold_interrupt are assigned to the respective >> function pointers when they are defined. > The "WTF?!" would still fire and we don't want that. Ah. Ok, I misunderstood. Will clear this. > Also, I'm not sure about returning MCE_PANIC_SEVERITY by default. > I mean, the code for !(Intel || AMD) has worked just fine with the > original severities, i.e., mce_severity_intel() now. > > So maybe we should assign mce_severity_intel() on static init of the > mce_severity pointer and override it only on AMD... > > This keeps the old behaviour for other machines, in the manner of > letting sleeping dogs lie... > Ok, I'll do that and resend. Thanks, -Aravind.