From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752810AbbCWOwC (ORCPT ); Mon, 23 Mar 2015 10:52:02 -0400 Received: from mail-wi0-f180.google.com ([209.85.212.180]:36682 "EHLO mail-wi0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752113AbbCWOv7 (ORCPT ); Mon, 23 Mar 2015 10:51:59 -0400 Message-ID: <5510288C.3020702@linaro.org> Date: Mon, 23 Mar 2015 14:51:56 +0000 From: Daniel Thompson User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Steven Rostedt CC: Peter Zijlstra , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , linux-kernel@vger.kernel.org, patches@linaro.org, linaro-kernel@lists.linaro.org, John Stultz , Sumit Semwal , Marc Zyngier , Andrew Thoelke , Dongdong Deng Subject: Re: [RFC PATCH 2/7] printk: Simple implementation for NMI backtracing References: <1426688428-3150-1-git-send-email-daniel.thompson@linaro.org> <1426688428-3150-3-git-send-email-daniel.thompson@linaro.org> <20150319133958.4821493e@gandalf.local.home> <20150319183037.GT23123@twins.programming.kicks-ass.net> <550B19EA.6000202@linaro.org> <20150319150111.778d21d3@gandalf.local.home> In-Reply-To: <20150319150111.778d21d3@gandalf.local.home> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19/03/15 19:01, Steven Rostedt wrote: > On Thu, 19 Mar 2015 18:48:10 +0000 > Daniel Thompson wrote: > \ >> The barrier was not intended to have anything to do with put_cpu() >> either though since the barrier was added before put_cpu() arrived: >> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=554ec063982752e9a569ab9189eeffa3d96731b2 >> >> There's nothing in the commit comment explaining the barrier and I >> really can't see what it is for. >> > > Looks like it wasn't needed then either. Agreed. I'll respin the patchset with the barrier removed. Daniel.