From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753038AbbCWPgL (ORCPT ); Mon, 23 Mar 2015 11:36:11 -0400 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:59850 "EHLO mx08-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752130AbbCWPgI (ORCPT ); Mon, 23 Mar 2015 11:36:08 -0400 Message-ID: <551032AA.3060906@st.com> Date: Mon, 23 Mar 2015 16:35:06 +0100 From: Giuseppe CAVALLARO User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Richard Cochran , CC: , Amir Vadai , Ariel Elior , Arnd Bergmann , Baolin Wang , Ben Hutchings , Bruce Allan , Carolyn Wyborny , Chris Metcalf , David Miller , Frank Li , Jeff Kirsher , John Stultz , Luwei Zhou , Matthew Vick , Michael Chan , Prashant Sreedharan , Shradha Shah , Solarflare linux maintainers , Sonic Zhang , =?ISO-8859-1?Q?Stefan_S=F8rensen?= , Thomas Gleixner , Tom Lendacky , Rayagond K Subject: Re: [PATCH net-next V2 17/23] ptp: stmmac: convert to the 64 bit get/set time methods. References: <009374d77dee7633ab0ef1a5d95182b45aaa3f18.1426973658.git.richardcochran@gmail.com> In-Reply-To: <009374d77dee7633ab0ef1a5d95182b45aaa3f18.1426973658.git.richardcochran@gmail.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.52.138.95] X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.13.68,1.0.33,0.0.0000 definitions=2015-03-23_03:2015-03-23,2015-03-23,1970-01-01 signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/21/2015 10:39 PM, Richard Cochran wrote: > This device stores the number of seconds in a 32 bit register. So > more work is needed on this driver before the year 2038 comes around. > > Compile tested only. I cannot perform tests on my side, unfortunately. I have no setup at this moment. Added Rayagond on copy too Peppe > > Signed-off-by: Richard Cochran > --- > drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c > index c5ee79d8..172f318 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c > @@ -105,7 +105,7 @@ static int stmmac_adjust_time(struct ptp_clock_info *ptp, s64 delta) > * Description: this function will read the current time from the > * hardware clock and store it in @ts. > */ > -static int stmmac_get_time(struct ptp_clock_info *ptp, struct timespec *ts) > +static int stmmac_get_time(struct ptp_clock_info *ptp, struct timespec64 *ts) > { > struct stmmac_priv *priv = > container_of(ptp, struct stmmac_priv, ptp_clock_ops); > @@ -135,7 +135,7 @@ static int stmmac_get_time(struct ptp_clock_info *ptp, struct timespec *ts) > * hardware clock. > */ > static int stmmac_set_time(struct ptp_clock_info *ptp, > - const struct timespec *ts) > + const struct timespec64 *ts) > { > struct stmmac_priv *priv = > container_of(ptp, struct stmmac_priv, ptp_clock_ops); > @@ -168,8 +168,8 @@ static struct ptp_clock_info stmmac_ptp_clock_ops = { > .pps = 0, > .adjfreq = stmmac_adjust_freq, > .adjtime = stmmac_adjust_time, > - .gettime = stmmac_get_time, > - .settime = stmmac_set_time, > + .gettime64 = stmmac_get_time, > + .settime64 = stmmac_set_time, > .enable = stmmac_enable, > }; > >