From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752779AbbCWPvB (ORCPT <rfc822;w@1wt.eu>);
	Mon, 23 Mar 2015 11:51:01 -0400
Received: from aserp1040.oracle.com ([141.146.126.69]:37316 "EHLO
	aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752158AbbCWPvA (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 23 Mar 2015 11:51:00 -0400
Message-ID: <5510365D.6070109@oracle.com>
Date: Mon, 23 Mar 2015 18:50:53 +0300
From: Alexey Kodanev <alexey.kodanev@oracle.com>
User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.4.0
MIME-Version: 1.0
To: Eric Dumazet <eric.dumazet@gmail.com>
CC: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: tcp6: fix double call of tcp_v6_fill_cb()
References: <1427107090-4100-1-git-send-email-alexey.kodanev@oracle.com> <1427121492.25985.68.camel@edumazet-glaptop2.roam.corp.google.com>
In-Reply-To: <1427121492.25985.68.camel@edumazet-glaptop2.roam.corp.google.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Source-IP: userv0021.oracle.com [156.151.31.71]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Eric,
On 03/23/2015 05:38 PM, Eric Dumazet wrote:
> On Mon, 2015-03-23 at 13:38 +0300, Alexey Kodanev wrote:
> \
>> @@ -1538,7 +1525,7 @@ do_time_wait:
>>   					    &ipv6_hdr(skb)->saddr, th->source,
>>   					    &ipv6_hdr(skb)->daddr,
>>   					    ntohs(th->dest), tcp_v6_iif(skb));
>> -		if (sk2 != NULL) {
>> +		if (sk2) {
>>   			struct inet_timewait_sock *tw = inet_twsk(sk);
>>   			inet_twsk_deschedule(tw, &tcp_death_row);
>>   			inet_twsk_put(tw);
> And please refrain adding such cleanup changes in a bug fix.

Sure, I will. Thank you for review!

Best regards,
Alexey

> Thanks !
>
>