* Renaming ARM_CCI
@ 2015-03-23 15:10 Valentin Rothberg
2015-03-23 15:17 ` Suzuki K. Poulose
0 siblings, 1 reply; 4+ messages in thread
From: Valentin Rothberg @ 2015-03-23 15:10 UTC (permalink / raw)
To: suzuki.poulose, linux
Cc: sudeep.holla, nicolas.pitre, punit.agrawal, will.deacon,
linux-arm-kernel, linux-samsung-soc, linux-kernel, Paul Bolle,
Andreas Ruprecht, hengelein Stefan
Hi Suzuki,
your commit c9966c98697a ("arm-cci: Split the code for PMU vs driver
support") renames the Kconfig option ARM_CCI to ARM_CCI400_PORT_CTRL.
However, the commit does not rename all references on ARM_CCI:
drivers/bus/Kconfig:29: select ARM_CCI
drivers/bus/Makefile:6:obj-$(CONFIG_ARM_CCI) += arm-cci.o
include/linux/arm-cci.h:31:#ifdef CONFIG_ARM_CCI
Is this intentional or is there a patch scheduled somewhere to fix this issue?
I detected your commit with scripts/checkkconfigsymbols.py. A recent
patch added support to make the script git aware, so that it lets you
check git commits. It's added to Greg's misc tree and should arrive
soon in linux-next.
[linux-next]$ ./checkkconfigsymbols.py --diff next-20150320..next-20150323
ARM_CCI drivers/bus/Makefile, include/linux/arm-cci.h, drivers/bus/Kconfig
Kind regards,
Valentin
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: Renaming ARM_CCI
2015-03-23 15:10 Renaming ARM_CCI Valentin Rothberg
@ 2015-03-23 15:17 ` Suzuki K. Poulose
2015-03-23 16:04 ` Suzuki K. Poulose
0 siblings, 1 reply; 4+ messages in thread
From: Suzuki K. Poulose @ 2015-03-23 15:17 UTC (permalink / raw)
To: Valentin Rothberg, linux@arm.linux.org.uk
Cc: Sudeep Holla, nicolas.pitre@linaro.org, Punit Agrawal,
Will Deacon, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
Paul Bolle, Andreas Ruprecht, hengelein Stefan
On 23/03/15 15:10, Valentin Rothberg wrote:
> Hi Suzuki,
>
> your commit c9966c98697a ("arm-cci: Split the code for PMU vs driver
> support") renames the Kconfig option ARM_CCI to ARM_CCI400_PORT_CTRL.
> However, the commit does not rename all references on ARM_CCI:
>
It renames, but still, leaves the ARM_CCI to build the arm-cci.o, which
is in the original commit.
> drivers/bus/Kconfig:29: select ARM_CCI
> drivers/bus/Makefile:6:obj-$(CONFIG_ARM_CCI) += arm-cci.o
> include/linux/arm-cci.h:31:#ifdef CONFIG_ARM_CCI
>
> Is this intentional or is there a patch scheduled somewhere to fix this issue?
Yes, it is. This problem was introduced due to a conflict in the linux-next.
See :
https://lkml.org/lkml/2015/3/22/240
Cheers
Suzuki
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: Renaming ARM_CCI
2015-03-23 15:17 ` Suzuki K. Poulose
@ 2015-03-23 16:04 ` Suzuki K. Poulose
2015-03-23 16:06 ` Valentin Rothberg
0 siblings, 1 reply; 4+ messages in thread
From: Suzuki K. Poulose @ 2015-03-23 16:04 UTC (permalink / raw)
To: Valentin Rothberg, linux@arm.linux.org.uk
Cc: Sudeep Holla, nicolas.pitre@linaro.org, Punit Agrawal,
Will Deacon, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
Paul Bolle, Andreas Ruprecht, hengelein Stefan
On 23/03/15 15:17, Suzuki K. Poulose wrote:
> On 23/03/15 15:10, Valentin Rothberg wrote:
>> Hi Suzuki,
>>
>> your commit c9966c98697a ("arm-cci: Split the code for PMU vs driver
>> support") renames the Kconfig option ARM_CCI to ARM_CCI400_PORT_CTRL.
>> However, the commit does not rename all references on ARM_CCI:
>>
> It renames, but still, leaves the ARM_CCI to build the arm-cci.o, which
> is in the original commit.
>
>> drivers/bus/Kconfig:29: select ARM_CCI
>> drivers/bus/Makefile:6:obj-$(CONFIG_ARM_CCI) += arm-cci.o
>> include/linux/arm-cci.h:31:#ifdef CONFIG_ARM_CCI
>>
>> Is this intentional or is there a patch scheduled somewhere to fix this issue?
> Yes, it is. This problem was introduced due to a conflict in the linux-next.
>
> See :
> https://lkml.org/lkml/2015/3/22/240
Somehow, the link above doesn't link my response to the thread.
Please find it below.
https://lkml.org/lkml/2015/3/23/484
Suzuki
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: Renaming ARM_CCI
2015-03-23 16:04 ` Suzuki K. Poulose
@ 2015-03-23 16:06 ` Valentin Rothberg
0 siblings, 0 replies; 4+ messages in thread
From: Valentin Rothberg @ 2015-03-23 16:06 UTC (permalink / raw)
To: Suzuki K. Poulose
Cc: linux@arm.linux.org.uk, Sudeep Holla, nicolas.pitre@linaro.org,
Punit Agrawal, Will Deacon, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
Paul Bolle, Andreas Ruprecht, hengelein Stefan
On Mon, Mar 23, 2015 at 5:04 PM, Suzuki K. Poulose
<Suzuki.Poulose@arm.com> wrote:
> On 23/03/15 15:17, Suzuki K. Poulose wrote:
>>
>> On 23/03/15 15:10, Valentin Rothberg wrote:
>>>
>>> Hi Suzuki,
>>>
>>> your commit c9966c98697a ("arm-cci: Split the code for PMU vs driver
>>> support") renames the Kconfig option ARM_CCI to ARM_CCI400_PORT_CTRL.
>>> However, the commit does not rename all references on ARM_CCI:
>>>
>> It renames, but still, leaves the ARM_CCI to build the arm-cci.o, which
>> is in the original commit.
>>
>>> drivers/bus/Kconfig:29: select ARM_CCI
>>> drivers/bus/Makefile:6:obj-$(CONFIG_ARM_CCI) += arm-cci.o
>>> include/linux/arm-cci.h:31:#ifdef CONFIG_ARM_CCI
>>>
>>> Is this intentional or is there a patch scheduled somewhere to fix this
>>> issue?
>>
>> Yes, it is. This problem was introduced due to a conflict in the
>> linux-next.
>>
>> See :
>> https://lkml.org/lkml/2015/3/22/240
>
> Somehow, the link above doesn't link my response to the thread.
> Please find it below.
>
> https://lkml.org/lkml/2015/3/23/484
Thank you for the answer and the explanation.
Kind regards,
Valentin
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-03-23 16:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-23 15:10 Renaming ARM_CCI Valentin Rothberg
2015-03-23 15:17 ` Suzuki K. Poulose
2015-03-23 16:04 ` Suzuki K. Poulose
2015-03-23 16:06 ` Valentin Rothberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox