Re: [PATCH v9 tip 5/9] tracing: allow BPF programs to call bpf_trace_printk()

Ingo Molnar
2015-03-22T11:10:48Z

* Alexei Starovoitov <ast@plumgrid.com> wrote:

> +static const struct bpf_func_proto bpf_trace_printk_proto = {
> + .func = bpf_trace_printk,
> + .gpl_only = true,
> + .ret_type = RET_INTEGER,
> + .arg1_type = ARG_PTR_TO_STACK,
> + .arg2_type = ARG_CONST_STACK_SIZE,
> +};

A nit, please align such initializations vertically, for more
readability:

static const struct bpf_func_proto bpf_trace_printk_proto = {
.func = bpf_trace_printk,
.gpl_only = true,
.ret_type = RET_INTEGER,
.arg1_type = ARG_PTR_TO_STACK,
.arg2_type = ARG_CONST_STACK_SIZE,
};

(this applies to other patches as well.)

Thanks,

Ingo