From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753236AbbCWTPw (ORCPT ); Mon, 23 Mar 2015 15:15:52 -0400 Received: from avasout02.plus.net ([212.159.14.17]:60184 "EHLO avasout02.plus.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752285AbbCWTPs (ORCPT ); Mon, 23 Mar 2015 15:15:48 -0400 X-CM-Score: 0.00 X-CNFS-Analysis: v=2.1 cv=IsmQcdPg c=1 sm=1 tr=0 a=VGUxJGZ/H8UixBFj6Q9CRg==:117 a=VGUxJGZ/H8UixBFj6Q9CRg==:17 a=0Bzu9jTXAAAA:8 a=XuYyiiJQKFMA:10 a=N659UExz7-8A:10 a=eIRpCU4CAAAA:8 a=CNB__giTomBi7uSijvkA:9 a=pILNOxqGKmIA:10 X-AUTH: oscars+hm@:2500 Message-ID: <55106663.5060802@hmbedded.co.uk> Date: Mon, 23 Mar 2015 19:15:47 +0000 From: Howard Mitchell User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Mark Brown , Peter Rosin CC: "tiwai@suse.de" , "lgirdwood@gmail.com" , "perex@perex.cz" , "robh+dt@kernel.org" , "pawel.moll@arm.com" , "mark.rutland@arm.com" , "ijc+devicetree@hellion.org.uk" , "galak@codeaurora.org" , "devicetree@vger.kernel.org" , "alsa-devel@alsa-project.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] ASoC:pcm512x: Make PLL lock output selectable via device tree. References: <1426886563-10936-1-git-send-email-hm@hmbedded.co.uk> <20150322162409.GG6643@sirena.org.uk> <550FE05F.6070204@hmbedded.co.uk> <105aef6a0e21488d8661d2a2823515d8@EMAIL.axentia.se> <20150323165621.GH14954@sirena.org.uk> In-Reply-To: <20150323165621.GH14954@sirena.org.uk> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23/03/15 16:56, Mark Brown wrote: > On Mon, Mar 23, 2015 at 11:00:53AM +0000, Peter Rosin wrote: > >> Strongly agreed that we should fix this before it is published (I assumed >> that is was included in 3.19, it felt so long ago that Mark merged it...). My >> preference would be to remove the pll-lock things entirely though. Assuming >> you don't need it for your board of course, but I doubt it from your description. >> I used it to make sure I had understood the chip correctly, that's all. > It didn't make v3.19 so if we're very quick we can get this in as a fix. > Can someone resend a version which splits this into two patches, one > deleting the existing code to configure GPIO 4 and the other adding the > configurability? I can then send the removal as a bug fix to v4.0 so we > don't have any compatibility issues and add the new feature for v4.1. Ok, will do, although it seems that both Peter and I agree that the configurability is not required, so I'll just submit a patch for the deletion. - Howard