From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753553AbbCXA1c (ORCPT ); Mon, 23 Mar 2015 20:27:32 -0400 Received: from mail-qg0-f49.google.com ([209.85.192.49]:36840 "EHLO mail-qg0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752200AbbCXA1b (ORCPT ); Mon, 23 Mar 2015 20:27:31 -0400 Message-ID: <5510AF6B.6030907@ti.com> Date: Mon, 23 Mar 2015 19:27:23 -0500 From: Nishanth Menon Reply-To: nm@ti.com User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Mark Salter , Aurelien Jacquiot CC: linux-c6x-dev@linux-c6x.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] C6x: time: Ensure consistency in __init References: <1425721145-4807-1-git-send-email-nm@ti.com> In-Reply-To: <1425721145-4807-1-git-send-email-nm@ti.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 03/07/2015 03:39 AM, Nishanth Menon wrote: > time_init invokes timer64_init (which is __init annotation) > since all of these are invoked at init time, lets maintain > consistency by ensuring time_init is marked appropriately > as well. > > This fixes the following warning with CONFIG_DEBUG_SECTION_MISMATCH=y > > WARNING: vmlinux.o(.text+0x3bfc): Section mismatch in reference from the function time_init() to the function .init.text:timer64_init() > The function time_init() references > the function __init timer64_init(). > This is often because time_init lacks a __init > annotation or the annotation of timer64_init is wrong. > > Fixes: 546a39546c64 ("C6X: time management") > Signed-off-by: Nishanth Menon > --- > > Newbie warning: this is my first foray at c6x, So, appreciate a little > gentleness while killing me ;) > > Applies on latest master: > af13e867133a Merge branch 'drm-fixes' of git://people.freedesktop.org/~airlied/linux > Gentle ping. > > arch/c6x/kernel/time.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/c6x/kernel/time.c b/arch/c6x/kernel/time.c > index 356ee84cad95..04845aaf5985 100644 > --- a/arch/c6x/kernel/time.c > +++ b/arch/c6x/kernel/time.c > @@ -49,7 +49,7 @@ u64 sched_clock(void) > return (tsc * sched_clock_multiplier) >> SCHED_CLOCK_SHIFT; > } > > -void time_init(void) > +void __init time_init(void) > { > u64 tmp = (u64)NSEC_PER_SEC << SCHED_CLOCK_SHIFT; > > -- Regards, Nishanth Menon