[PATCH] C6x: time: Ensure consistency in __init

[PATCH] C6x: time: Ensure consistency in __init

[Nishanth Menon]

time_init invokes timer64_init (which is __init annotation)
since all of these are invoked at init time, lets maintain
consistency by ensuring time_init is marked appropriately
as well.

This fixes the following warning with CONFIG_DEBUG_SECTION_MISMATCH=y

WARNING: vmlinux.o(.text+0x3bfc): Section mismatch in reference from the function time_init() to the function .init.text:timer64_init()
The function time_init() references
the function __init timer64_init().
This is often because time_init lacks a __init
annotation or the annotation of timer64_init is wrong.

Fixes: 546a39546c64 ("C6X: time management")
Signed-off-by: Nishanth Menon <nm@ti.com>
---

Newbie warning: this is my first foray at c6x, So, appreciate a little
gentleness while killing me ;)

Applies on latest master:
af13e867133a Merge branch 'drm-fixes' of git://people.freedesktop.org/~airlied/linux


 arch/c6x/kernel/time.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/c6x/kernel/time.c b/arch/c6x/kernel/time.c
index 356ee84cad95..04845aaf5985 100644
--- a/arch/c6x/kernel/time.c
+++ b/arch/c6x/kernel/time.c
@@ -49,7 +49,7 @@ u64 sched_clock(void)
 	return (tsc * sched_clock_multiplier) >> SCHED_CLOCK_SHIFT;
 }
 
-void time_init(void)
+void __init time_init(void)
 {
 	u64 tmp = (u64)NSEC_PER_SEC << SCHED_CLOCK_SHIFT;
 
-- 
1.9.1

Re: [PATCH] C6x: time: Ensure consistency in __init

[Nishanth Menon]

Hi,

On 03/07/2015 03:39 AM, Nishanth Menon wrote:
> time_init invokes timer64_init (which is __init annotation)
> since all of these are invoked at init time, lets maintain
> consistency by ensuring time_init is marked appropriately
> as well.
> 
> This fixes the following warning with CONFIG_DEBUG_SECTION_MISMATCH=y
> 
> WARNING: vmlinux.o(.text+0x3bfc): Section mismatch in reference from the function time_init() to the function .init.text:timer64_init()
> The function time_init() references
> the function __init timer64_init().
> This is often because time_init lacks a __init
> annotation or the annotation of timer64_init is wrong.
> 
> Fixes: 546a39546c64 ("C6X: time management")
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
> 
> Newbie warning: this is my first foray at c6x, So, appreciate a little
> gentleness while killing me ;)
> 
> Applies on latest master:
> af13e867133a Merge branch 'drm-fixes' of git://people.freedesktop.org/~airlied/linux
> 

Gentle ping.

> 
>  arch/c6x/kernel/time.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/c6x/kernel/time.c b/arch/c6x/kernel/time.c
> index 356ee84cad95..04845aaf5985 100644
> --- a/arch/c6x/kernel/time.c
> +++ b/arch/c6x/kernel/time.c
> @@ -49,7 +49,7 @@ u64 sched_clock(void)
>  	return (tsc * sched_clock_multiplier) >> SCHED_CLOCK_SHIFT;
>  }
>  
> -void time_init(void)
> +void __init time_init(void)
>  {
>  	u64 tmp = (u64)NSEC_PER_SEC << SCHED_CLOCK_SHIFT;
>  
> 
--
Regards,
Nishanth Menon

Re: [PATCH] C6x: time: Ensure consistency in __init

[Mark Salter]

On Mon, 2015-03-23 at 19:27 -0500, Nishanth Menon wrote:
> Hi,
> 
> On 03/07/2015 03:39 AM, Nishanth Menon wrote:
> > time_init invokes timer64_init (which is __init annotation)
> > since all of these are invoked at init time, lets maintain
> > consistency by ensuring time_init is marked appropriately
> > as well.
> > 
> > This fixes the following warning with CONFIG_DEBUG_SECTION_MISMATCH=y
> > 
> > WARNING: vmlinux.o(.text+0x3bfc): Section mismatch in reference from the function time_init() to the function .init.text:timer64_init()
> > The function time_init() references
> > the function __init timer64_init().
> > This is often because time_init lacks a __init
> > annotation or the annotation of timer64_init is wrong.
> > 
> > Fixes: 546a39546c64 ("C6X: time management")
> > Signed-off-by: Nishanth Menon <nm@ti.com>
> > ---
> > 
> > Newbie warning: this is my first foray at c6x, So, appreciate a little
> > gentleness while killing me ;)
> > 
> > Applies on latest master:
> > af13e867133a Merge branch 'drm-fixes' of git://people.freedesktop.org/~airlied/linux
> > 
> 
> Gentle ping.

Thanks! I added this to the c6x tree for next merge window.

> 
> > 
> >  arch/c6x/kernel/time.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/c6x/kernel/time.c b/arch/c6x/kernel/time.c
> > index 356ee84cad95..04845aaf5985 100644
> > --- a/arch/c6x/kernel/time.c
> > +++ b/arch/c6x/kernel/time.c
> > @@ -49,7 +49,7 @@ u64 sched_clock(void)
> >  	return (tsc * sched_clock_multiplier) >> SCHED_CLOCK_SHIFT;
> >  }
> >  
> > -void time_init(void)
> > +void __init time_init(void)
> >  {
> >  	u64 tmp = (u64)NSEC_PER_SEC << SCHED_CLOCK_SHIFT;
> >  
> > 
> --
> Regards,
> Nishanth Menon