From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752637AbbCXICl (ORCPT ); Tue, 24 Mar 2015 04:02:41 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:28577 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752275AbbCXICd (ORCPT ); Tue, 24 Mar 2015 04:02:33 -0400 X-AuditID: cbfee691-f79b86d000004a5a-08-55111a16280a Message-id: <55111A16.4090800@samsung.com> Date: Tue, 24 Mar 2015 17:02:30 +0900 From: Beomho Seo User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-version: 1.0 To: Krzysztof Kozlowski Cc: Lee Jones , Sebastian Reichel , Jaewon Kim , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux-input@vger.kernel.org, Inki Dae , SangBae Lee , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Chanwoo Choi , Dmitry Torokhov Subject: Re: [PATCH v7 3/5] power: max77843_battery: Add Max77843 fuel gauge device driver References: <1425291038-18269-1-git-send-email-jaewon02.kim@samsung.com> <1425291038-18269-4-git-send-email-jaewon02.kim@samsung.com> <20150307201426.GG5233@earth> <54FCEB17.70809@samsung.com> <54FEF52E.7060409@samsung.com> In-reply-to: <54FEF52E.7060409@samsung.com> Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrPIsWRmVeSWpSXmKPExsWyRsSkUFdMSjDUYNIEFYvrX56zWsw/co7V 4vCiF4wW/W8Wslqce7WS0WLS/QksFjsajrBavH5haHH/61FGi5ufvrFaXN41h83ic+8RRoul 1y8yWUyYvpbFonXvEXaL458Oslic3l3iIOixZt4aRo/Lfb1MHjtn3WX3WLn8C5vHplWdbB53 ru1h8+jbsorR4/MmuQCOKC6blNSczLLUIn27BK6MI88fMhZ08Fe8XbCLrYFxOk8XIweHhICJ xLvLuV2MnECmmMSFe+vZQGwhgaWMElcWMEHETSTOPn/B3MXIBRSfziixYfVOFgjnAaPE1aVf GEGqeAW0JL5sXcsIMpRFQFXi/dUUkDCbgKbE+ylXWEDCogIRErcvc0JUC0r8mHyPBcQWETCU OLh7OxPISGaBYywSyxYuAUsIC8RIbOg6CbVrDZNEx58/YLs4BbQl5kw6ygYylFlAXWLKFLAH mAXkJTaveQt2qITAWg6JRzf7wAaxCAhIfJt8iAXiYVmJTQeYIR6TlDi44gbLBEaxWUhumoUw dRaSqQsYmVcxiqYWJBcUJ6UXmeoVJ+YWl+al6yXn525iBMb76X/PJu5gvH/A+hCjAAejEg9v wBKBUCHWxLLiytxDjKZAR0xklhJNzgcmlbySeENjMyMLUxNTYyNzSzMlcV4d6Z/BQgLpiSWp 2ampBalF8UWlOanFhxiZODilGhjTpeXememvq+D4zWov8uSflv0j5fd9le2lb+7qXmv2jb9t eD9+7o2o7MJV4eEcgtyXv7tOmtZ0/gbvtRf1Wdmetpt3zjTvmzvp3ZN/8Zn2goKfNfwa2q8c Mlbh2Hxq56e6rfPTPtfXSs8JyLOumRd56s7cLzWVFhcfVPaeMC7imvNwQ/oZ4+NKLMUZiYZa zEXFiQDrOnWr8gIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrNKsWRmVeSWpSXmKPExsVy+t9jQV0xKcFQg/1d0hbXvzxntZh/5Byr xeFFLxgt+t8sZLU492olo8Wk+xNYLHY0HGG1eP3C0OL+16OMFjc/fWO1uLxrDpvF594jjBZL r19kspgwfS2LReveI+wWxz8dZLE4vbvEQdBjzbw1jB6X+3qZPHbOusvusXL5FzaPTas62Tzu XNvD5tG3ZRWjx+dNcgEcUQ2MNhmpiSmpRQqpecn5KZl56bZK3sHxzvGmZgaGuoaWFuZKCnmJ uam2Si4+AbpumTlAbygplCXmlAKFAhKLi5X07TBNCA1x07WAaYzQ9Q0JgusxMkADCWsYM448 f8hY0MFf8XbBLrYGxuk8XYycHBICJhJnn79ghrDFJC7cW8/WxcjFISQwnVFiw+qdLBDOA0aJ q0u/MIJU8QpoSXzZuhbI5uBgEVCVeH81BSTMJqAp8X7KFRaQsKhAhMTty5wQ1YISPybfYwGx RQQMJQ7u3s4EMpJZ4BiLxLKFS8ASwgIxEhu6TkLtWsMk0fHnD9guTgFtiTmTjrKBDGUWUJeY MiUXJMwsIC+xec1b5gmMArOQ7JiFUDULSdUCRuZVjKKpBckFxUnpuUZ6xYm5xaV56XrJ+bmb GMEJ5Zn0DsZVDRaHGAU4GJV4eAOWCIQKsSaWFVfmHmKU4GBWEuH1vgwU4k1JrKxKLcqPLyrN SS0+xGgK9P9EZinR5HxgsssriTc0NjEzsjQyN7QwMjZXEudVsm8LERJITyxJzU5NLUgtgulj 4uCUamDssPomrvEhJ9tIzUG8OEjpyCtPzYMPPFTX1Qvtvtcx0WpBK2/hWlG9G6J6dY6XX9z/ LyH7/bvnmf8S7/XermHy/Vf0uVPVo73j6LsHy8/NftTy7OJnwYBdMfN7VJ0+z2O+o7/bfJr3 nZ9bZfbc55vz0MFURO3MPWnVG1vdrJf25+n1FS2QnvVaiaU4I9FQi7moOBEAU1779j4DAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/10/2015 10:44 PM, Beomho Seo wrote: > On 03/09/2015 07:01 PM, Krzysztof Kozlowski wrote: >> 2015-03-09 1:36 GMT+01:00 Beomho Seo : >>> On 03/08/2015 05:14 AM, Sebastian Reichel wrote: >>>> Hi, >>>> >>>> On Mon, Mar 02, 2015 at 07:10:36PM +0900, Jaewon Kim wrote: >>>>> From: Beomho Seo >>>>> >>>>> This patch adds device driver of max77843 fuel gauge. >>>>> The driver support for battery fuel gauge in Maxim Max77843. >>>>> It is fuel-gauge systems for lithuum-ion batteries in handled and >>>>> portable devices. >>>>> >>>>> Cc: Sebastian Reichel >>>>> Signed-off-by: Beomho Seo >>>> >>>> Reviewed-By: Sebastian Reichel >>>> >>>> I can't take it as is, since it depends on the private header file >>>> of PATCH 1. >>>> >>>> -- Sebastian >>>> >>> >>> This patch reviewed by Sebastian. >>> Could you Please merge that your git tree ? >> >> Hi, >> >> Sorry for late response, but I finally got some time to look at this. >> This driver looks very similar to max17042_battery.c fuel gauge >> driver. Obtaining some properties looks exactly the same. The >> difference seems to be in new properties. The I2C address is the same. >> >> I highly recommend to extend the max17042 driver instead. It already >> supports also max17047, max17050 and max77693. >> >> Best regards, >> Krzysztof >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-pm" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> > > OK. I will follow your opinion about fuel gauge. I will extend the max17042 driver. > After test on my board, I will send a new patch set. > > Best regards, > Beomho Seo Krzysztof, gentle ping? I will extend the max17042 driver. Best regards, Beomho Seo