From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934040AbbCROQz (ORCPT ); Wed, 18 Mar 2015 10:16:55 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:55144 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933385AbbCROQw convert rfc822-to-8bit (ORCPT ); Wed, 18 Mar 2015 10:16:52 -0400 X-AuditID: cbfee61b-f79d76d0000024d6-cd-550988d12aab From: Bartlomiej Zolnierkiewicz To: Krzysztof Kozlowski Cc: Kukjin Kim , Kukjin Kim , linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org, Daniel Lezcano , Tomasz Figa , linux-kernel@vger.kernel.org, Chanwoo Choi , Kyungmin Park , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 1/4] ARM: EXYNOS: fix CPU1 hotplug for AFTR mode on Exynos3250 Date: Wed, 18 Mar 2015 15:16:45 +0100 Message-id: <5511908.Xj1ZIW6HbI@amdc1032> User-Agent: KMail/4.8.4 (Linux/3.2.0-70-generic-pae; KDE/4.8.5; i686; ; ) In-reply-to: <1426685545.23982.2.camel@AMDC1943> References: <1426683113-31209-1-git-send-email-b.zolnierkie@samsung.com> <3449559.PngGo6WKuq@amdc1032> <1426685545.23982.2.camel@AMDC1943> MIME-version: 1.0 Content-transfer-encoding: 8BIT Content-type: text/plain; charset=UTF-8 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrILMWRmVeSWpSXmKPExsVy+t9jAd2LHZyhBqs2aFlc//Kc1WLeZ1mL 1y8MLXoXXGWz6H/8mtnibNMbdotNj6+xWlzeNYfN4nPvEUaLGef3MVms2vWH0YHbY+esu+we m1Z1snncubaHzWPzknqPvi2rGD0+b5ILYIvisklJzcksSy3St0vgytizRLxgLk/F1kkn2RoY d3J2MXJySAiYSKzeP40NwhaTuHBvPZDNxSEksIhRYsmRY+wQTguTxIEZ91lBqtgErCQmtq9i BLFFBAwlDu7ezgRSxCzwiUmi5/Z0JpCEsEC4xOzDb4AaODhYBFQl+judQUxeAU2JdZvUQCpE BTwldk4/ADaGU8BA4vOXk1C7ehgl7u45D5bgFRCU+DH5HguIzSygLfHk3QVWCFtdYtK8RcwT GAVmISmbhaRsFpKyBYzMqxhFUwuSC4qT0nON9IoTc4tL89L1kvNzNzGCI+KZ9A7GVQ0WhxgF OBiVeHglrnKECrEmlhVX5h5ilOBgVhLhrW7kDBXiTUmsrEotyo8vKs1JLT7EKM3BoiTOq2Tf FiIkkJ5YkpqdmlqQWgSTZeLglGpg9OlNsI6pfxVgyuU/mUfmTdKRWK73NusOpDT+WPtX78i/ P7+fX1JL2HbzwAq2JXJMomfWXjA7WML3VFzCa8LGL7yWvrePXPrxJYMppv+k26S3bE+8XeKz nplO9ROfkWf8UmXJM6ZFO9u0RUu+bE+32v1/m3pnjtW0jqgTy7a/d3jz098qWPGfmhJLcUai oRZzUXEiAM0BsC+EAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday, March 18, 2015 02:32:25 PM Krzysztof Kozlowski wrote: > On śro, 2015-03-18 at 14:23 +0100, Bartlomiej Zolnierkiewicz wrote: > > Hi, > > > > On Wednesday, March 18, 2015 02:10:31 PM Krzysztof Kozlowski wrote: > > > 2015-03-18 13:51 GMT+01:00 Bartlomiej Zolnierkiewicz : > > > > > > > > + while (!pmu_raw_readl(S5P_PMU_SPARE2)) > > > > + udelay(10); > > > > + udelay(10); > > > > > > We really need to start documenting this. Please add short description > > > why this SPARE2 check is here and who uses it. Without documenting > > > this behavior future generations won't be able to debug this stuff. > > > Imagine replacing sboot with uboot by someone... > > > > I've already planned to do this for this code and for coupled cpuidle > > use of SPARE2 as well. However I would really prefer to do it in > > an incremental patch if there are no other issues with this patchset. > > OK, please do so in incremental patch. Usage of various memory regions OK. > of sysram also should be documented. In patch 2 you add usage of 0x28 + > 4*cpu. The various sysrams regions are spread over different files... I completely agree that there should be some Documentation file with the SYSRAM layout. I'll do it later unless someone beats me to it (please also add this to our internal TODO list of open issues, thanks!). Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics