From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932388AbbCXSuU (ORCPT ); Tue, 24 Mar 2015 14:50:20 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:56085 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754807AbbCXSuP (ORCPT ); Tue, 24 Mar 2015 14:50:15 -0400 Message-ID: <5511B1EC.7080406@ti.com> Date: Tue, 24 Mar 2015 20:50:20 +0200 From: Tero Kristo User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Peter Ujfalusi , , CC: , , Subject: Re: [PATCH 0/2] clk: ti: OMAP3: McBSP clock fixes References: <1426502458-6124-1-git-send-email-peter.ujfalusi@ti.com> In-Reply-To: <1426502458-6124-1-git-send-email-peter.ujfalusi@ti.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/16/2015 12:40 PM, Peter Ujfalusi wrote: > Hi, > > This series will fix the following error during boot (both DT and legacy boot): > [ 0.307739] omap_hwmod: mcbsp2: _wait_target_ready failed: -16 > [ 0.307769] omap_hwmod: mcbsp2: cannot be enabled for reset (3) > > The clock definitions/aliases for McBSP ports were not correct. > > In case of DT boot we still have the following warning printed from hwmod: > [ 0.222900] omap_hwmod: mcbsp2_sidetone using broken dt data from mcbsp > [ 0.225311] omap_hwmod: mcbsp3_sidetone using broken dt data from mcbsp > > These are there because mcbsp is using two hwmods in the DT and hwmod prints > out a warning for these. In legacy mode we also have 2 hwmods for McBSP2/3. > One for the McBSP itself and the other for the sidetone block attached to them. > I'll try to look into this one next. > > Since this series fixes the _wait_target_ready issue, can this be sent for 4.0? I don't think this is a critical fix, the wait_target_ready issue has been around for ages. Queued for 4.1 though, thanks. -Tero > > Regards, > Peter > --- > Peter Ujfalusi (2): > clk: ti: clk-3xxx: Correct McBSP related DT clock definitions > clk: ti: clk-3xxx-legacy: Correct McBSP related clock aliases > > drivers/clk/ti/clk-3xxx-legacy.c | 16 +++++++++------- > drivers/clk/ti/clk-3xxx.c | 19 +++++++------------ > 2 files changed, 16 insertions(+), 19 deletions(-) >