linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chris Metcalf <cmetcalf@ezchip.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@kernel.org>,
	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Frederic Weisbecker <fweisbec@gmail.com>
Subject: Re: [PATCH 1/4] tile: support arch_irq_work_raise
Date: Tue, 24 Mar 2015 18:06:26 -0400	[thread overview]
Message-ID: <5511DFE2.4010605@ezchip.com> (raw)
In-Reply-To: <20150324211406.GB27490@worktop.programming.kicks-ass.net>

On 3/24/2015 5:14 PM, Peter Zijlstra wrote:
> On Tue, Mar 24, 2015 at 03:21:32PM -0400, cmetcalf@ezchip.com wrote:
>> From: Chris Metcalf <cmetcalf@ezchip.com>
>>
>> Tile includes a hypervisor hook to deliver messages to arbitrary
>> tiles, so we can use that to raise an interrupt as soon as
>> possible on our own core.  Unfortunately the Tilera hypervisor
>> disabled that support on principle in previous releases, but
>> it will be available in MDE 4.3.4 and later.
> Can you program a timer in the (recent) past which will instantly
> trigger an interrupt? This is what PPC64 does to implement the self-ipi.

I looked in git history a bit and see commit 105988c015943 from 2009,
which looks like it was the basis for the powerpc support.  I'm a little leery
of just randomly changing the in-flight timer decrementer value, though;
does the timer event_handler properly handle being called early, and
then properly handle resetting the decrementer to the right value?
I guess if both of those things are true, it seems plausible to adopt the
approach you suggested.

On the other hand, the approach I coded up avoids making any of those
slightly scary assumptions about the timer subsystem, and I don't really
have a problem with saying you need a recent Tilera hypervisor binary if
you want to use NOHZ_FULL...

-- 
Chris Metcalf, EZChip Semiconductor
http://www.ezchip.com


  reply	other threads:[~2015-03-24 22:06 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-24 19:21 [PATCH 0/4] initial NOHZ_FULL support for tile cmetcalf
2015-03-24 19:21 ` [PATCH 1/4] tile: support arch_irq_work_raise cmetcalf
2015-03-24 21:00   ` Frederic Weisbecker
2015-03-24 21:14   ` Peter Zijlstra
2015-03-24 22:06     ` Chris Metcalf [this message]
2015-03-25  8:03       ` Peter Zijlstra
2015-03-24 19:21 ` [PATCH 2/4] tile: support CONTEXT_TRACKING and thus NOHZ_FULL cmetcalf
2015-03-24 21:15   ` Frederic Weisbecker
2015-03-24 21:49     ` Chris Metcalf
2015-03-24 19:21 ` [PATCH 3/4] nohz: add tick_nohz_full_clear_cpus() API cmetcalf
2015-03-30 16:20   ` Chris Metcalf
2015-03-30 16:41     ` Rik van Riel
2015-03-30 16:45       ` Chris Metcalf
2015-03-24 19:21 ` [PATCH 4/4] net: tile: don't send interrupts to nohz cores by default cmetcalf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5511DFE2.4010605@ezchip.com \
    --to=cmetcalf@ezchip.com \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).