From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752872AbbCXXHa (ORCPT ); Tue, 24 Mar 2015 19:07:30 -0400 Received: from mail-wi0-f175.google.com ([209.85.212.175]:33728 "EHLO mail-wi0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752845AbbCXXH1 (ORCPT ); Tue, 24 Mar 2015 19:07:27 -0400 Message-ID: <5511EE2B.4040109@linaro.org> Date: Tue, 24 Mar 2015 23:07:23 +0000 From: Srinivas Kandagatla User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Mark Brown CC: linux-arm-kernel@lists.infradead.org, Maxime Ripard , Rob Herring , Kumar Gala , Greg Kroah-Hartman , linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, arnd@arndb.de, sboyd@codeaurora.org Subject: Re: [PATCH v3 2/9] regmap: Introduce regmap_get_reg_stride. References: <1427236116-18531-1-git-send-email-srinivas.kandagatla@linaro.org> <1427236200-18625-1-git-send-email-srinivas.kandagatla@linaro.org> <20150324223745.GC28997@sirena.org.uk> In-Reply-To: <20150324223745.GC28997@sirena.org.uk> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24/03/15 22:37, Mark Brown wrote: > On Tue, Mar 24, 2015 at 10:30:00PM +0000, Srinivas Kandagatla wrote: > >> + /* regmap_get_reg_stride(): Report the register address stride >> + * >> + * Report the register address stride, mainly intended to for use by >> + * generic infrastructure built on top of regmap. >> + */ >> +int regmap_get_reg_stride(struct regmap *map) > > Please fix the indentation for the comment block and add kerneldoc for > the argument. This is an exported function so it should also be /** not > /* > My bad.. I will fix it in next version.