Re: [PATCH 01/17] x86, fpu: wrap get_xsave_addr() to make it safer

Oleg Nesterov
2015-03-25T14:18:28Z

On 03/25, Borislav Petkov wrote:
>
> On Tue, Mar 24, 2015 at 09:01:44PM -0400, Rik van Riel wrote:
> > Indeed, __save_init_fpu (yeah, terrible name) will save
> > the in-register state to memory for you, so you can
> > inspect it.
> >
> > Is there any reason not to rename __save_init_fpu to
> > save_fpu_state, or just save_fpu?
>
> That whole place there needs more rubbing.
>
> So the way I see it, the "init" thing also says that the FPU is intact.

Yes, this is my understanding too.

And note that nobody actually wants this "init" part, so it actually
means "destroy".

I agree we should rename it later (at least). Plus unlazy_fpu() looks
confusing too. Nobody actually wants to "unlazy", the callers want to
save FPU state. So it could be named save_fpu_state() too ;)

Oleg.