From: Jens Axboe <axboe@kernel.dk>
To: David Rientjes <rientjes@google.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Tejun Heo <tj@kernel.org>,
Lars Ellenberg <drbd-dev@lists.linbit.com>,
drbd-user@lists.linbit.com, linux-kernel@vger.kernel.org
Subject: Re: [patch resend 1/3] block: allocate request memory local to request queue
Date: Tue, 24 Mar 2015 20:01:21 -0600 [thread overview]
Message-ID: <551216F1.4010907@kernel.dk> (raw)
In-Reply-To: <alpine.DEB.2.10.1503241620190.21805@chino.kir.corp.google.com>
On 03/24/2015 05:21 PM, David Rientjes wrote:
> blk_init_rl() allocates a mempool using mempool_create_node() with node
> local memory. This only allocates the mempool and element list locally
> to the requeue queue node.
>
> What we really want to do is allocate the request itself local to the
> queue. To do this, we need our own alloc and free functions that will
> allocate from request_cachep and pass the request queue node in to prefer
> node local memory.
Applied to for-4.1/core, thanks.
--
Jens Axboe
prev parent reply other threads:[~2015-03-25 2:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-24 23:21 [patch resend 1/3] block: allocate request memory local to request queue David Rientjes
2015-03-24 23:22 ` [patch resend 2/3] block, drbd: fix drbd_req_new() initialization David Rientjes
2015-03-25 2:01 ` Jens Axboe
2015-03-24 23:22 ` [patch resend 3/3] block, drbd: use mempool_create_slab_pool() David Rientjes
2015-03-25 2:01 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=551216F1.4010907@kernel.dk \
--to=axboe@kernel.dk \
--cc=akpm@linux-foundation.org \
--cc=drbd-dev@lists.linbit.com \
--cc=drbd-user@lists.linbit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rientjes@google.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox