From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752548AbbCYC02 (ORCPT ); Tue, 24 Mar 2015 22:26:28 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:52253 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752340AbbCYC0Z convert rfc822-to-8bit (ORCPT ); Tue, 24 Mar 2015 22:26:25 -0400 X-AuditID: cbfee68f-f791c6d000004834-39-55121ccf97ee MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 8BIT Message-id: <55121CDA.4020703@samsung.com> Date: Wed, 25 Mar 2015 11:26:34 +0900 From: Seung-Woo Kim Reply-to: sw0312.kim@samsung.com User-Agent: Mozilla/5.0 (X11; Linux i686; rv:16.0) Gecko/20121011 Thunderbird/16.0.1 To: Rob Clark Cc: Stephane Viau , "dri-devel@lists.freedesktop.org" , linux-arm-msm , Linux Kernel Mailing List , Beeresh Gopal , Inki Dae , Daniel Vetter , Seung-Woo Kim , m.szyprowski@samsung.com, s.nawrocki@samsung.com, k.debski@samsung.com Subject: Re: [PATCH v2 2/2] drm/msm/mdp4: Support NV12MT format in mdp4 References: <1426273930-12788-1-git-send-email-sviau@codeaurora.org> <1426273930-12788-3-git-send-email-sviau@codeaurora.org> <20150316080238.GA21993@phenom.ffwll.local> In-reply-to: X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrMIsWRmVeSWpSXmKPExsWyRsSkRPe8jFCowdVVPBb/t01ktrjy9T2b xeSjO5ktJt2fwGLx4/UFNouJ+8+yW1zeNYfNYu2Ru+wWzxf+YLY4/Kad1aJjzxd2ixmTX7I5 8Hhc7utl8tj7bQGLx85Zd9k97ncfZ/Lo27KK0ePzJrkAtigum5TUnMyy1CJ9uwSujIV7nrMW PJCq+L2kj62B8bhoFyMHh4SAicTtuQldjJxAppjEhXvr2boYuTiEBJYySvQd3McGkTCR2H7g JTuILSQwnVHi4HpzEJtXQFDix+R7LCA2s4C6xKR5i5hBZjILiEicuBsIEdaWWLbwNTPEzAeM Em/nfWKF6NWSmNb1iwnEZhFQlfh4ZBrYfDYBHYn9S36zQuxSkLgy8Rg7yExRgTCJnZvTQcIi AsoSq7buZwGZySywl1mideNZRpCEsIC7xLa9Dxghlu1lkngw5yszSIJTIFji3bFeVpCEhMBE DolvPT3MEJsFJL5NPsQCCQlZiU0HmCEelpQ4uOIGywRGiVlI/pyF5M9ZCH/OQvLnAkaWVYyi qQXJBcVJ6UXGesWJucWleel6yfm5mxiBcX/637P+HYx3D1gfYhTgYFTi4fUQEQoVYk0sK67M PcRoCnTQRGYp0eR8YHLJK4k3NDYzsjA1MTU2Mrc0UxLnXSj1M1hIID2xJDU7NbUgtSi+qDQn tfgQIxMHp1QD4/Qg/5l6yW+Dnk+uU7p70kWpd0kW9zdG4ySDJJ37LWbu39/PTTpd5vLmdFPD pP7YmVpXLLz//0z3YZuxqXv7Q9Nl64REfd/o8tssr90kZfNt2+eCrzLqD2LUdb6mXFhd7PVu itUZ09XbjjRuZtpgzPb/3+M3yvt/60TPUO95mqwiOn3flDvmhkosxRmJhlrMRcWJAN8YP5r2 AgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprGKsWRmVeSWpSXmKPExsVy+t9jQd3zMkKhBheOslj83zaR2eLK1/ds FpOP7mS2mHR/AovFj9cX2Cwm7j/LbnF51xw2i7VH7rJbPF/4g9ni8Jt2VouOPV/YLWZMfsnm wONxua+XyWPvtwUsHjtn3WX3uN99nMmjb8sqRo/Pm+QC2KIaGG0yUhNTUosUUvOS81My89Jt lbyD453jTc0MDHUNLS3MlRTyEnNTbZVcfAJ03TJzgK5UUihLzCkFCgUkFhcr6dthmhAa4qZr AdMYoesbEgTXY2SABhLWMGZM23eDqeCIVMXJHZdYGhhXi3YxcnJICJhIbD/wkh3CFpO4cG89 G4gtJDCdUeLgenMQm1dAUOLH5HssXYwcHMwC8hJHLmWDhJkF1CUmzVvE3MXIBVT+gFHi7bxP rBD1WhLTun4xgdgsAqoSH49MA5vPJqAjsX/Jb1aI+QoSVyYeYweZKSoQJrFzczpIWERAWWLV 1v0sIDOZBfYyS7RuPMsIkhAWcJfYtvcBI8SyvUwSD+Z8ZQZJcAoES7w71ss6gVFwFpJbZyHc OgvJrQsYmVcxiqYWJBcUJ6XnGukVJ+YWl+al6yXn525iBKeJZ9I7GFc1WBxiFOBgVOLh9RAR ChViTSwrrsw9xCjBwawkwmsgARTiTUmsrEotyo8vKs1JLT7EaAr06URmKdHkfGAKyyuJNzQ2 MTOyNDI3tDAyNlcS51WybwsREkhPLEnNTk0tSC2C6WPi4JRqYFyfznPz1rF9Z94YrbT0bvl9 Lc6hcrmx6ssziifeOp/P1ROo5d6SKBL7ruCtyedVakxXTuj/3FEeU5oVtnTphAfdulGfQw6q zOOPdvppf7G+/RGX1+n1qUvt7z/t37N4mk74fK6z5/mO650QXxvEsryJ41FfJr9IZ93NXwYv rtdZfr94i/n/5kVKLMUZiYZazEXFiQB95o1oKQMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On 2015년 03월 25일 03:32, Rob Clark wrote: > On Mon, Mar 16, 2015 at 4:05 AM, Daniel Vetter wrote: >> On Fri, Mar 13, 2015 at 03:12:10PM -0400, Stephane Viau wrote: >>> From: Beeresh Gopal >>> >>> Using fb modifier flag, support NV12MT format in MDP4. >>> >>> v2: >>> - rework the modifier's description [Daniel Vetter's comment] >>> - drop .set_mode_config() callback [Rob Clark's comment] >>> >>> Signed-off-by: Beeresh Gopal >>> Signed-off-by: Stephane Viau >>> --- >>> drivers/gpu/drm/msm/mdp/mdp4/mdp4_kms.c | 2 ++ >>> drivers/gpu/drm/msm/mdp/mdp4/mdp4_plane.c | 22 ++++++++++++++++++++++ >>> include/uapi/drm/drm_fourcc.h | 5 +++++ >>> 3 files changed, 29 insertions(+) >>> >>> diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h >>> index 188e61f..2ff79cb 100644 >>> --- a/include/uapi/drm/drm_fourcc.h >>> +++ b/include/uapi/drm/drm_fourcc.h >>> @@ -161,4 +161,9 @@ >>> * authoritative source for all of these. >>> */ >>> >>> +/* Samsung framebuffer modifiers */ >>> + >>> +/* Tiled: 64x32 pixel macroblocks */ >> >> Since this seems shared by a lot of vendors (I still don't believe Samsung >> invented this really ...) can you please describe this thing a bit in more >> detail? Somewhat important how macroblocks are laid out and pixels within. >> Also with a planar format like NV12 "pixel" is a bit unclear, e.g. what >> happens if you throw 10bit plane formats at this? So maybe also add a note >> that for now this is only used together with NV12T. > > + a couple folks from Samsung, since I expect they want this for > exynos as well (and might be able to help with the description) Yes, I have a plan to apply fb_modifier for exynos with kms interface of hdmi. > > vl4 also has this format, but last I looked was rather light on the details. I am not sure msm mdp uses exactly same format with exynos, but anyway v4l2 NV12MT format was introduced for exynos hw video codec. macro blocks for the format is laid z-order and each pixel data in each macro block is just normal NV12 style. I think Marek and Sylwester can help understanding the format. > > http://linuxtv.org/downloads/v4l-dvb-apis/re31.html > > I know up in userspace, GStreamer seems to have some support for this format: > > http://cgit.freedesktop.org/gstreamer/gst-plugins-base/commit/?id=f8d3b9b4fcc5e08b771314fa95e9ed8f750b54e6 > >> Then there's the question of validating the input - stride should probably >> be a full multiple of the macroblock size. Since this is a shared format >> imo this kind of checking should be done in drm core. > > afaiu, stride (and maybe even width?) should be a multiple of the > block size (but height does not) > > BR, > -R > > >> -Daniel >> >> >>> +#define DRM_FORMAT_MOD_SAMSUNG_64_32_TILE fourcc_mod_code(SAMSUNG, 1) >>> + >>> #endif /* DRM_FOURCC_H */ >>> -- >>> Qualcomm Innovation Center, Inc. >>> >>> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project >>> >> >> -- >> Daniel Vetter >> Software Engineer, Intel Corporation >> +41 (0) 79 365 57 48 - http://blog.ffwll.ch > -- Seung-Woo Kim Samsung Software R&D Center --