From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752387AbbCYDcT (ORCPT ); Tue, 24 Mar 2015 23:32:19 -0400 Received: from mail-pa0-f50.google.com ([209.85.220.50]:34955 "EHLO mail-pa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751328AbbCYDcQ (ORCPT ); Tue, 24 Mar 2015 23:32:16 -0400 Message-ID: <55122C2B.6010603@gmail.com> Date: Wed, 25 Mar 2015 09:01:55 +0530 From: Varka Bhadram User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Ingi Kim , cooloney@gmail.com, rpurdie@rpsys.net, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org CC: sakari.ailus@iki.fi, j.anaszewski@samsung.com, sw0312.kim@samsung.com, cw00.choi@samsung.com, jh80.chung@samsung.com, ideal.song@samsung.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org Subject: Re: [PATCH v4 2/3] leds: ktd2692: add device tree bindings for ktd2692 References: <1427247044-3748-1-git-send-email-ingi2.kim@samsung.com> <1427247044-3748-3-git-send-email-ingi2.kim@samsung.com> In-Reply-To: <1427247044-3748-3-git-send-email-ingi2.kim@samsung.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/25/2015 07:00 AM, Ingi Kim wrote: > This patch adds the device tree bindings for ktd2692 flash LEDs. > Add optional properties 'flash-timeout-us' to control flash timeout > and 'vin-supply' for flash-led regulator > > Signed-off-by: Ingi Kim > --- > .../devicetree/bindings/leds/leds-ktd2692.txt | 33 ++++++++++++++++++++++ > 1 file changed, 33 insertions(+) > create mode 100644 Documentation/devicetree/bindings/leds/leds-ktd2692.txt > > diff --git a/Documentation/devicetree/bindings/leds/leds-ktd2692.txt b/Documentation/devicetree/bindings/leds/leds-ktd2692.txt > new file mode 100644 > index 0000000..f78512f > --- /dev/null > +++ b/Documentation/devicetree/bindings/leds/leds-ktd2692.txt > @@ -0,0 +1,33 @@ > +* Kinetic Technologies - KTD2692 Flash LED Driver > + > +KTD2692 is the ideal power solution for high-power flash LEDs. > +It uses ExpressWire single-wire programming for maximum flexibility. > + > +The ExpressWire interface through CTRL pin can control LED on/off and > +enable/disable the IC, Movie(max 1/3 of Flash current) / Flash mode current, > +Flash timeout, LVP(low voltage protection). > + > +Also, When the AUX pin is pulled high while CTRL pin is high, > +LED current will be ramped up to the flash-mode current level. > + > +Required properties: > + - compatible: "kinetic,ktd2692" > + - ctrl-gpio, aux-gpio : gpio pins in order control ktd2692 flash led. > + There is an internal 300kOhm pull-down resistor at each pin > + - vin-supply : "vin" LED supply (2.7V to 5.5V) > + See Documentation/devicetree/bindings/regulator/regulator.txt > + Above bindings are not that readable to me. Remove the tab spaces before properties. > +Optional property: > + - flash-timeout-us : Maximum flash timeout in microseconds. > + flash timeout ranges from 0 to 1835000us and > + default is 1049000us. > + > +Example: > + > +flash-led { > + compatible = "kinetic,ktd2692"; > + ctrl-gpio = <&gpc0 1 0>; > + aux-gpio = <&gpc0 2 0>; > + flash-timeout-us = <1835000>; > + vin-supply = <&vbat>; > +}; -- Varka Bhadram