linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joe Mario <jmario@redhat.com>
To: David Ahern <dsahern@gmail.com>, Don Zickus <dzickus@redhat.com>
Cc: acme@kernel.org, linux-kernel@vger.kernel.org,
	Jiri Olsa <jolsa@redhat.com>
Subject: Re: [PATCH] perf tool: Fix ppid for synthesized fork events
Date: Wed, 25 Mar 2015 08:22:34 -0400	[thread overview]
Message-ID: <5512A88A.1010608@redhat.com> (raw)
In-Reply-To: <5511D349.7070508@gmail.com>

On 03/24/2015 05:12 PM, David Ahern wrote:
> On 3/24/15 2:10 PM, Don Zickus wrote:
>> He does this with and without the patch.  The difference is usually over 50%
>> extra time with the patch for both the record timings and report timings.:-(
>
> I find that shocking. The patch only populates ppid and ptid with a value read from the file that is already opened and processed. Most of the patch is just plumbing the value from the low level function that processes the status file back to synthesize_fork.
>
> What benchmark is this? Is it something I can download and run? if so, details? site, command, args?
>
> Thanks,
> David

Hi David:

We ran "time perf mem record -a -e cpu/mem-loads,ldlat=50/pp -e cpu/mem-stores/pp sleep 10" on a system that was running SPECjbb2013 in the background.  There were about 10,000 java threads with about 500 to 800 in a runnable state at any given time.   We ran it on a 4 socket x86 IVB server.

We had two perf binaries.  One with your patch and one without it.  Because the benchmark doesn't always have a constant load, we ran the above perf command in a loop alternating between the patched and unpatched version.   The elapsed wall clock times ("real" field from time) for the perf with your patch was typically >= 50% longer than the equivalent unpatched perf.

We can't give out a copy of the SPEC benchmark (part of the SPEC agreement).  Try to find some application (or create your own) to load the system with lots of busy threads.

Joe

  reply	other threads:[~2015-03-25 12:22 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-19 17:41 [PATCH] perf tool: Fix ppid for synthesized fork events David Ahern
2015-03-19 20:56 ` Don Zickus
2015-03-19 21:06   ` David Ahern
2015-03-20 14:01     ` Arnaldo Carvalho de Melo
2015-03-24 20:10     ` Don Zickus
2015-03-24 21:12       ` David Ahern
2015-03-25 12:22         ` Joe Mario [this message]
2015-03-25 13:24           ` Arnaldo Carvalho de Melo
2015-03-25 15:03             ` David Ahern
2015-03-25 19:20               ` Don Zickus
2015-03-25 16:57           ` David Ahern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5512A88A.1010608@redhat.com \
    --to=jmario@redhat.com \
    --cc=acme@kernel.org \
    --cc=dsahern@gmail.com \
    --cc=dzickus@redhat.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).