Re: [PATCHv2 06/32] avr32: copy_thread(): rename 'arg' argument to 'kthread_arg'

Hans-Christian Egtvedt
2015-03-16T09:52:19Z

Around Mon 16 Mar 2015 10:18:29 +0200 or thereabout, Alex Dowad wrote:
> The 'arg' argument to copy_thread() is only ever used when forking a new
> kernel thread. Hence, rename it to 'kthread_arg' for clarity.
>
> Signed-off-by: Alex Dowad <alexinbeijing@gmail.com>

Acked-by: Hans-Christian Egtvedt <egtvedt@samfundet.no>

> ---
>
> Dear Hans-Christian Egtvedt,
>
> Thanks for your feedback! I have removed the unneeded comments.
>
> AD
>
> arch/avr32/kernel/process.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/arch/avr32/kernel/process.c b/arch/avr32/kernel/process.c
> index 42a53e74..a255bd3 100644
> --- a/arch/avr32/kernel/process.c
> +++ b/arch/avr32/kernel/process.c
> @@ -279,20 +279,25 @@ asmlinkage void ret_from_fork(void);
> asmlinkage void ret_from_kernel_thread(void);
> asmlinkage void syscall_return(void);
>
> +/*
> + * Copy architecture-specific thread state
> + */
> int copy_thread(unsigned long clone_flags, unsigned long usp,
> - unsigned long arg,
> + unsigned long kthread_arg,
> struct task_struct *p)
> {
> struct pt_regs *childregs = task_pt_regs(p);
>
> if (unlikely(p->flags & PF_KTHREAD)) {
> memset(childregs, 0, sizeof(struct pt_regs));
> - p->thread.cpu_context.r0 = arg;
> + p->thread.cpu_context.r0 = kthread_arg;
> p->thread.cpu_context.r1 = usp; /* fn */
> p->thread.cpu_context.r2 = (unsigned long)syscall_return;
> p->thread.cpu_context.pc = (unsigned long)ret_from_kernel_thread;
> childregs->sr = MODE_SUPERVISOR;
> } else {
> *childregs = *current_pt_regs();
> if (usp)
> childregs->sp = usp;
--
mvh
Hans-Christian Egtvedt