From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753545AbbCYOkn (ORCPT ); Wed, 25 Mar 2015 10:40:43 -0400 Received: from smtp102.biz.mail.bf1.yahoo.com ([98.139.221.61]:26641 "EHLO smtp102.biz.mail.bf1.yahoo.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752997AbbCYOkW (ORCPT ); Wed, 25 Mar 2015 10:40:22 -0400 X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: okibM4YVM1n.IZTjM9nGRvNlXklOdIlwG984NSc0lX2UTIH O8EnifIMMScRcahcCA9cLcS54QA7i8_A4eyiBAspePf5It11dvKSl88Ub40A ..uhyjO3UrDESEk7Knei7tzo2pMqdBk0T0zOvly6IYW_WOHZJNxekwO.it_Y FPA_52dfJJABlJc1qRFDHZRaYk6m_xQOff6_X6W2EIMDkkbROnRE18fl0xDg Sq2iGfLHGKYiU_3_edMwW28ts.urrVH3d4lTXtHnr2fsI3l_4RKbSe3.2nZ1 uhvLOofc8tgDAQmmFg7YFj1KOy9htGlvY6gMNe.fqCsYrkgwAI8ePZUcQjZF cIH0Wa2j134IQFPzdpjN0h.TNEygbTVuOutk.3BuPuUC6hbhOVDqSktjnODI 9Nz5Py5dkF8mkxKKMJEc_DRFxZELfFu8uIcUGVLpy4b8avWWeLGWLCeM4g1K AHjl23oq5Zp22Np0n6dnBdvLdBflTVMMzivNKAi8vnM7mLtKamBe.QRQ9K7M EULjbGKjBDv_rWYrFNkSY02ATv1iu24x7Ok88ool_Rrf.W1UCFNSg0VUpQvV RP4YLmzLmeDqls1X4Ck1VPXAUxdKrayglhxoXallD51T0PAaqWw_ejKZLxv_ F.yCMXQIyd6Hm X-Yahoo-SMTP: OIJXglSswBDfgLtXluJ6wiAYv6_cnw-- Message-ID: <5512C8D3.5060901@schaufler-ca.com> Date: Wed, 25 Mar 2015 07:40:19 -0700 From: Casey Schaufler User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Paul Gortmaker , James Morris , "Serge E. Hallyn" CC: linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] smack: Fix gcc warning from unused smack_syslog_lock mutex in smackfs.c References: <1427133797-7333-1-git-send-email-paul.gortmaker@windriver.com> In-Reply-To: <1427133797-7333-1-git-send-email-paul.gortmaker@windriver.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/23/2015 11:03 AM, Paul Gortmaker wrote: > In commit 00f84f3f2e9d088f06722f4351d67f5f577abe22 ("Smack: Make the > syslog control configurable") this mutex was added, but the rest of > the final commit never actually made use of it, resulting in: > > In file included from include/linux/mutex.h:29:0, > from include/linux/notifier.h:13, > from include/linux/memory_hotplug.h:6, > from include/linux/mmzone.h:821, > from include/linux/gfp.h:5, > from include/linux/slab.h:14, > from include/linux/security.h:27, > from security/smack/smackfs.c:21: > security/smack/smackfs.c:63:21: warning: ‘smack_syslog_lock’ defined but not used [-Wunused-variable] > static DEFINE_MUTEX(smack_syslog_lock); > ^ > > A git grep shows no other instances/references to smack_syslog_lock. > Delete it, assuming that the mutex addition was just a leftover from > an earlier work in progress version of the change. > > Signed-off-by: Paul Gortmaker Applied to git://git.gitorious.org/smack-next/kernel.git#smack-for-4.1 > --- > security/smack/smackfs.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/security/smack/smackfs.c b/security/smack/smackfs.c > index bce4e8f1b267..558a46d76129 100644 > --- a/security/smack/smackfs.c > +++ b/security/smack/smackfs.c > @@ -61,7 +61,6 @@ enum smk_inos { > */ > static DEFINE_MUTEX(smack_cipso_lock); > static DEFINE_MUTEX(smack_ambient_lock); > -static DEFINE_MUTEX(smack_syslog_lock); > static DEFINE_MUTEX(smk_netlbladdr_lock); > > /*