From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751864AbbCZBnK (ORCPT ); Wed, 25 Mar 2015 21:43:10 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:23839 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750819AbbCZBnH (ORCPT ); Wed, 25 Mar 2015 21:43:07 -0400 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 X-AuditID: cbfee68f-f791c6d000004834-7e-5513642826df Content-transfer-encoding: 8BIT Message-id: <55136428.70603@samsung.com> Date: Thu, 26 Mar 2015 10:43:04 +0900 From: Ingi Kim User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 To: Varka Bhadram Cc: cooloney@gmail.com, rpurdie@rpsys.net, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, sakari.ailus@iki.fi, j.anaszewski@samsung.com, sw0312.kim@samsung.com, cw00.choi@samsung.com, jh80.chung@samsung.com, ideal.song@samsung.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org Subject: Re: [PATCH v4 2/3] leds: ktd2692: add device tree bindings for ktd2692 References: <1427247044-3748-1-git-send-email-ingi2.kim@samsung.com> <1427247044-3748-3-git-send-email-ingi2.kim@samsung.com> <55122C2B.6010603@gmail.com> In-reply-to: <55122C2B.6010603@gmail.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrKIsWRmVeSWpSXmKPExsWyRsSkWFcjRTjU4MIjCYujOycyWVz/8pzV Yv6Rc6wW/W8Wslrs+nuf0eLcq5WMFr1XnzNa3PjVxmpxedccNoutb9YxWiy9fpHJYsL0tSwW rXuPsFvs3vWU1eLM/pVsFjMmv2SzONkxh9FB0GPNvDWMHpf7epk8ds66y+6xcvkXNo/DXxey eGxa1cnmsWf+D1aPvi2rGD0+b5IL4IzisklJzcksSy3St0vgyuhouc1ecECo4l1rK0sD4x2+ LkZODgkBE4lb+5YyQ9hiEhfurWfrYuTiEBJYyiixcuFlJpii+V+6GCESixglumYeZwdJ8AoI SvyYfI+li5GDg1lAXuLIpWwIU11iypRciPIHjBIfm1qYIco1JPYsXM0IYrMIqEo0X5gPNp9N QE3ixoqFTCC9ogIRErcvc4KYIgJaEmc+ioCMYRboYpZoev0OrFxYwF9i09ulLBDz5zFKvN9y AGw+p4CmxIvOG4wQN+/gkPjznxVil4DEt8mHwM6UEJCV2HQA6l9JiYMrbrBMYBSbheSZWQjP zEJ4ZgEj8ypG0dSC5ILipPQiY73ixNzi0rx0veT83E2MwNg//e9Z/w7GuwesDzEKcDAq8fB6 iAiFCrEmlhVX5h5iNAW6YSKzlGhyPjDB5JXEGxqbGVmYmpgaG5lbmimJ8y6U+hksJJCeWJKa nZpakFoUX1Sak1p8iJGJg1OqgVEwqeqlTZ7Kr+UizyI0zWac6G+ZHfPuidy6may7F66RifrH 5n8823Vr3kFnsVNPxPTv7roSd3+iJFv7TJYfvAqzDq95N7OlY24bi1LLApNZV46qPl/8yn1t 2NET+jXKn9JzuRV1PlgeCKqtNr327aq5ok3tESuDO1fuqMV8Y+FlumywIXj6zaNKLMUZiYZa zEXFiQAq+PNq+AIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrAKsWRmVeSWpSXmKPExsVy+t9jAV2NFOFQgxdTBSyO7pzIZHH9y3NW i/lHzrFa9L9ZyGqx6+99Rotzr1YyWvRefc5oceNXG6vF5V1z2Cy2vlnHaLH0+kUmiwnT17JY tO49wm6xe9dTVosz+1eyWcyY/JLN4mTHHEYHQY8189Ywelzu62Xy2DnrLrvHyuVf2DwOf13I 4rFpVSebx575P1g9+rasYvT4vEkugDOqgdEmIzUxJbVIITUvOT8lMy/dVsk7ON453tTMwFDX 0NLCXEkhLzE31VbJxSdA1y0zB+gbJYWyxJxSoFBAYnGxkr4dpgmhIW66FjCNEbq+IUFwPUYG aCBhDWNGR8tt9oIDQhXvWltZGhjv8HUxcnJICJhIzP/SxQhhi0lcuLeerYuRi0NIYBGjRNfM 4+wgCV4BQYkfk++xdDFycDALyEscuZQNYapLTJmSC1H+gFHiY1MLM0S5hsSehavBZrIIqEo0 X5jPBGKzCahJ3FixkAmkV1QgQuL2ZU4QU0RAS+LMRxGQMcwCXcwSTa/fgZULC/hLbHq7lAVi /jxGifdbDoDN5xTQlHjReYNxAqPALCTXzUK4bhbCdQsYmVcxiqYWJBcUJ6XnGukVJ+YWl+al 6yXn525iBKeWZ9I7GFc1WBxiFOBgVOLh9RARChViTSwrrsw9xCjBwawkwsuqJxwqxJuSWFmV WpQfX1Sak1p8iNEU6LeJzFKiyfnAtJdXEm9obGJmZGlkbmhhZGyuJM6rZN8WIiSQnliSmp2a WpBaBNPHxMEp1cDYs6j5g+i0mWGKrJ5+eeXp07g8JRg7RTk/cOZlzUlsvv4uqEJPRG3XhuJz 2Vzap8VuqR/xvHxR580EMefFGz4c3Ranum390iqfMifFxe67N0zevzFXS+RSo96PKtmZZWoL JXfdXSh4NtrJzvlyd+Wlqyzua20uSkxWuPSr/Xxy4Kv3e5+6nzRWYinOSDTUYi4qTgQAFwju JUMDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Varka, Thanks for the review On 2015년 03월 25일 12:31, Varka Bhadram wrote: > On 03/25/2015 07:00 AM, Ingi Kim wrote: >> This patch adds the device tree bindings for ktd2692 flash LEDs. >> Add optional properties 'flash-timeout-us' to control flash timeout >> and 'vin-supply' for flash-led regulator >> >> Signed-off-by: Ingi Kim >> --- >> .../devicetree/bindings/leds/leds-ktd2692.txt | 33 ++++++++++++++++++++++ >> 1 file changed, 33 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/leds/leds-ktd2692.txt >> >> diff --git a/Documentation/devicetree/bindings/leds/leds-ktd2692.txt b/Documentation/devicetree/bindings/leds/leds-ktd2692.txt >> new file mode 100644 >> index 0000000..f78512f >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/leds/leds-ktd2692.txt >> @@ -0,0 +1,33 @@ >> +* Kinetic Technologies - KTD2692 Flash LED Driver >> + >> +KTD2692 is the ideal power solution for high-power flash LEDs. >> +It uses ExpressWire single-wire programming for maximum flexibility. >> + >> +The ExpressWire interface through CTRL pin can control LED on/off and >> +enable/disable the IC, Movie(max 1/3 of Flash current) / Flash mode current, >> +Flash timeout, LVP(low voltage protection). >> + >> +Also, When the AUX pin is pulled high while CTRL pin is high, >> +LED current will be ramped up to the flash-mode current level. >> + >> +Required properties: >> + - compatible: "kinetic,ktd2692" >> + - ctrl-gpio, aux-gpio : gpio pins in order control ktd2692 flash led. >> + There is an internal 300kOhm pull-down resistor at each pin >> + - vin-supply : "vin" LED supply (2.7V to 5.5V) >> + See Documentation/devicetree/bindings/regulator/regulator.txt >> + > > Above bindings are not that readable to me. Remove the tab spaces before properties. > Isn't it clear? OK, I'll fix it more >> +Optional property: >> + - flash-timeout-us : Maximum flash timeout in microseconds. >> + flash timeout ranges from 0 to 1835000us and >> + default is 1049000us. >> + >> +Example: >> + >> +flash-led { >> + compatible = "kinetic,ktd2692"; >> + ctrl-gpio = <&gpc0 1 0>; >> + aux-gpio = <&gpc0 2 0>; >> + flash-timeout-us = <1835000>; >> + vin-supply = <&vbat>; >> +}; > >