From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752058AbbCZBn3 (ORCPT ); Wed, 25 Mar 2015 21:43:29 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:57866 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751899AbbCZBn0 convert rfc822-to-8bit (ORCPT ); Wed, 25 Mar 2015 21:43:26 -0400 X-AuditID: cbfee690-f79ab6d0000046f7-e1-55136438232a MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 8BIT Message-id: <55136438.9060303@samsung.com> Date: Thu, 26 Mar 2015 10:43:20 +0900 From: Ingi Kim User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 To: Varka Bhadram Cc: cooloney@gmail.com, rpurdie@rpsys.net, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, sakari.ailus@iki.fi, j.anaszewski@samsung.com, sw0312.kim@samsung.com, cw00.choi@samsung.com, jh80.chung@samsung.com, ideal.song@samsung.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org Subject: Re: [PATCH v4 3/3] leds: Add ktd2692 flash LED driver References: <1427247044-3748-1-git-send-email-ingi2.kim@samsung.com> <1427247044-3748-4-git-send-email-ingi2.kim@samsung.com> <55122B59.7050404@gmail.com> In-reply-to: <55122B59.7050404@gmail.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrDIsWRmVeSWpSXmKPExsWyRsSkQNciRTjUYP9sBYujOycyWVz/8pzV Yv6Rc6wW/W8Wslrs+nuf0eLcq5WMFr1XnzNa3PjVxmpxedccNoutb9YxWiy9fpHJYsL0tSwW rXuPsFvs3vWU1eLM/pVsFjMmv2SzONkxh9FB0GPNvDWMHpf7epk8ds66y+6xcvkXNo/DXxey eGxa1cnmsWf+D1aPvi2rGD0+b5IL4IzisklJzcksSy3St0vgymjdu4ip4IFOxbXVs1kaGL8o djFycEgImEhsfOjQxcgJZIpJXLi3nq2LkYtDSGApo8Stjk2MEAkTic1LfrJCJKYzSsxYeoEZ JMErICjxY/I9FpBBzALqElOm5EKYIhKP/xaAVDALaEssW/iaGaL1AaPEl55LTBCtWhKH950C G8MioCqxes4ndhCbTUBN4saKhUwgc0QFIiRuX+YEMUWAys98FAEZwyzQxSzR9PodWImwgJ3E kQccEOPnMUo8XHqTDWQMp4CmxK6NV8FOlhDYwSFxcdtLVohdAhLfJh9igfhdVmLTAWaIFyUl Dq64wTKBUXwWksdmITw2C+GxWUgeW8DIsopRNLUguaA4Kb3IRK84Mbe4NC9dLzk/dxMjMFGc /vdswg7GewesDzEKcDAq8fB6iAiFCrEmlhVX5h5iNAW6ZyKzlGhyPjAd5ZXEGxqbGVmYmpga G5lbmimJ876W+hksJJCeWJKanZpakFoUX1Sak1p8iJGJg1OqgVF4hngZ/7k0393tAuuuv/a/ tY31glOgxvd1P6tVb3iv0mPO/fBuMk9F9s0J91bs4lj6P99lbeXK/vMv7nlnva+ZdUVtvn3G 0Wtcv3dvPzidiWHniQ1ut6NqK21UXayyV96x2u8/4/CWVm32fY/WZSVqLL62O9Uvabb2mh47 UWejU3fSOQKP6+opsRRnJBpqMRcVJwIAMBlpcg8DAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrPKsWRmVeSWpSXmKPExsVy+t9jQV2LFOFQg6t3xSyO7pzIZHH9y3NW i/lHzrFa9L9ZyGqx6+99Rotzr1YyWvRefc5oceNXG6vF5V1z2Cy2vlnHaLH0+kUmiwnT17JY tO49wm6xe9dTVosz+1eyWcyY/JLN4mTHHEYHQY8189Ywelzu62Xy2DnrLrvHyuVf2DwOf13I 4rFpVSebx575P1g9+rasYvT4vEkugDOqgdEmIzUxJbVIITUvOT8lMy/dVsk7ON453tTMwFDX 0NLCXEkhLzE31VbJxSdA1y0zB+gbJYWyxJxSoFBAYnGxkr4dpgmhIW66FjCNEbq+IUFwPUYG aCBhDWPGkf1LGQuadCqmf9rE0sA4TbGLkZNDQsBEYvOSn6wQtpjEhXvr2boYuTiEBKYzSsxY eoEZJMErICjxY/I9li5GDg5mAXmJI5eyIUx1iSlTciHKHzBKfOm5xARRriVxeN8psFYWAVWJ 1XM+sYPYbAJqEjdWLGQC6RUViJC4fZkTxBQBKj/zUQRkDLNAF7NE0+t3YCXCAnYSRx5wQIyf xyjxcOlNNpAxnAKaErs2XmWdwCgwC8lxsxCOm4Vw3AJG5lWMoqkFyQXFSem5hnrFibnFpXnp esn5uZsYwYnlmdQOxpUNFocYBTgYlXh4PUSEQoVYE8uKK3MPMUpwMCuJ8LLqCYcK8aYkVlal FuXHF5XmpBYfYjQFem0is5Rocj4w6eWVxBsam5gZWRqZG1oYGZsrifMq2beFCAmkJ5akZqem FqQWwfQxcXBKNTD2fPvE0rzr8b4YzoL50m+05IWl3XSO2mjsPbp4T39dYLONZs6Oo0U+f5kO RLky7Vp3+4aaSCvfyT+ytsVh51/NFH8gn9oVs2LmH8/369oP5hq78m44PWWhYVMyx9QEE9VQ zqqQT/69KzdJPG2yLeGTidC823gn/6OJx5dmX12mumMyridOOiixFGckGmoxFxUnAgA5z1Dr QgMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Varka, On 2015년 03월 25일 12:28, Varka Bhadram wrote: > On 03/25/2015 07:00 AM, Ingi Kim wrote: > >> This patch adds a driver to support the ktd2692 flash LEDs. >> ktd2692 can control flash current by ExpressWire interface. >> >> Signed-off-by: Ingi Kim >> --- >> drivers/leds/Kconfig | 9 + >> drivers/leds/Makefile | 1 + >> drivers/leds/leds-ktd2692.c | 412 ++++++++++++++++++++++++++++++++++++++++++++ >> 3 files changed, 422 insertions(+) >> create mode 100644 drivers/leds/leds-ktd2692.c >> > (...) > >> +static int ktd2692_parse_dt(struct ktd2692_context *led, struct device *dev, >> + u32 *flash_timeout_us) >> +{ >> + struct device_node *np = dev->of_node; >> + > > Unnecessary one line space.. > Oh, I missed it! Thanks >> + int ret; >> + >> + led->ctrl_gpio = of_get_named_gpio(np, "ctrl-gpio", 0); >> + if (!gpio_is_valid(led->ctrl_gpio)) { >> + dev_err(dev, "no ctrl-gpio property found\n"); >> + return -EINVAL; >> + } >> + >> + led->aux_gpio = of_get_named_gpio(np, "aux-gpio", 0); >> + if (!gpio_is_valid(led->aux_gpio)) { >> + dev_err(dev, "no aux-gpio property found\n"); >> + return -EINVAL; >> + } >> + >> + ret = devm_gpio_request_one(dev, led->ctrl_gpio, >> + GPIOF_OPEN_SOURCE, "ctrl-gpio"); >> + if (ret) { >> + dev_err(dev, "failed to request ctrl-gpio %d error %d\n", >> + led->ctrl_gpio, ret); >> + return ret; >> + } >> + >> + ret = devm_gpio_request_one(dev, led->aux_gpio, >> + GPIOF_OPEN_SOURCE, "aux-gpio"); >> + if (ret) { >> + dev_err(dev, "failed to request aux-gpio %d error %d\n", >> + led->aux_gpio, ret); >> + return ret; >> + } >> + >> + ret = of_property_read_u32(np, "flash-timeout-us", flash_timeout_us); >> + /* default setting */ >> + if (ret) >> + *flash_timeout_us = KTD2692_FLASH_MODE_TIMEOUT_DEFAULT_US; >> + >> + return 0; >> +} >> + >> +static const struct led_flash_ops flash_ops = { >> + .strobe_set = ktd2692_led_flash_strobe_set, >> + .timeout_set = ktd2692_led_flash_timeout_set, >> +}; >> + >> +static int ktd2692_probe(struct platform_device *pdev) >> +{ >> + struct ktd2692_context *led; >> + struct led_classdev *led_cdev; >> + struct led_classdev_flash *fled_cdev; >> + struct led_flash_setting flash_timeout; >> + u32 flash_timeout_us; >> + int ret; >> + >> + led = devm_kzalloc(&pdev->dev, sizeof(*led), GFP_KERNEL); >> + if (!led) >> + return -ENOMEM; >> + >> + if (!pdev->dev.of_node) >> + return -ENXIO; >> + > > Above operation dt related. So if you do that in ktd2692_parse_dt(), it will be good > Good point! I'll do that >> + fled_cdev = &led->fled_cdev; >> + led_cdev = &fled_cdev->led_cdev; >> + >> + ret = ktd2692_parse_dt(led, &pdev->dev, &flash_timeout_us); >> + if (ret) >> + return ret; >> + >> + led->regulator = devm_regulator_get(&pdev->dev, "vin"); >> + if (IS_ERR(led->regulator)) { >> + dev_err(&pdev->dev, "regulator get failed\n"); >> + return PTR_ERR(led->regulator); >> + } >> + >> + ktd2692_init_flash_timeout(flash_timeout_us, &flash_timeout); >> + >> + fled_cdev->timeout = flash_timeout; >> + fled_cdev->ops = &flash_ops; >> + >> + led_cdev->name = KTD2692_DEFAULT_NAME; >> + led_cdev->brightness_set = ktd2692_led_brightness_set; >> + led_cdev->brightness_set_sync = ktd2692_led_brightness_set_sync; >> + led_cdev->flags |= LED_CORE_SUSPENDRESUME; >> + led_cdev->flags |= LED_DEV_CAP_FLASH; >> + >> + mutex_init(&led->lock); >> + INIT_WORK(&led->work_brightness_set, ktd2692_brightness_set_work); >> + >> + platform_set_drvdata(pdev, led); >> + >> + ret = led_classdev_flash_register(&pdev->dev, fled_cdev); >> + if (ret) { >> + dev_err(&pdev->dev, "can't register LED %s\n", led_cdev->name); >> + cancel_work_sync(&led->work_brightness_set); > > Is the above API is correct to use in this place.? > > cancel_work_sync — cancel a work and wait for it to finish... > > Work is not yet scheduled..? > > What about mutex destroy..? > Right, I should remove this API. It seems to be useless in this place And mutex_destroy() will be added, Thank you! >> + return ret; >> + } >> + >> + ktd2692_setup(led); >> + ktd2692_led_regulator_enable(led); >> + >> + return 0; >> +} >> + >> +static int ktd2692_remove(struct platform_device *pdev) >> +{ >> + struct ktd2692_context *led = platform_get_drvdata(pdev); >> + >> + ktd2692_led_regulator_disable(led); >> + led_classdev_flash_unregister(&led->fled_cdev); >> + cancel_work_sync(&led->work_brightness_set); >> + >> + mutex_destroy(&led->lock); >> + >> + return 0; >> +} >> + >> +static const struct of_device_id ktd2692_match[] = { >> + { .compatible = "kinetic,ktd2692", }, >> + { /* sentinel */ }, >> +}; >> + >> +static struct platform_driver ktd2692_driver = { >> + .driver = { >> + .name = "leds-ktd2692", >> + .of_match_table = ktd2692_match, >> + }, >> + .probe = ktd2692_probe, >> + .remove = ktd2692_remove, >> +}; >> + >> +module_platform_driver(ktd2692_driver); >> + >> +MODULE_AUTHOR("Ingi Kim "); >> +MODULE_DESCRIPTION("Kinetic KTD2692 LED driver"); >> +MODULE_LICENSE("GPL v2"); > >