From: "Pádraig Brady" <P@draigBrady.com>
To: Steven Rostedt <rostedt@goodmis.org>,
Luis Henriques <luis.henriques@canonical.com>
Cc: Shuah Khan <shuahkh@osg.samsung.com>,
Namhyung Kim <namhyung@kernel.org>,
linux-kernel@vger.kernel.org,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Subject: Re: [PATCH] ftracetest: replace usleep by sleep
Date: Thu, 26 Mar 2015 02:50:50 +0000 [thread overview]
Message-ID: <5513740A.6040500@draigBrady.com> (raw)
In-Reply-To: <20150325145758.6466c7a1@gandalf.local.home>
On 25/03/15 18:57, Steven Rostedt wrote:
> On Wed, 25 Mar 2015 17:36:34 +0000
> Luis Henriques <luis.henriques@canonical.com> wrote:
>
>> 'usleep' seems to be a distro-specific utility and may not be
>> available:
>>
>> [5] event tracing - enable/disable with event level files [FAIL]
>> execute: /home/miguel/linux/tools/testing/selftests/ftrace/test.d/event/event-enable.tc
>> + . /home/miguel/linux/tools/testing/selftests/ftrace/test.d/event/event-enable.tc
>> + [ ! -f set_event -o ! -d events/sched ]
>> + reset_tracer
>> + echo nop
>> + do_reset
>> + echo
>> + clear_trace
>> + echo
>> + echo sched:sched_switch
>> + usleep 1
>> ./ftracetest: 24: /home/miguel/linux/tools/testing/selftests/ftrace/test.d/event/event-enable.tc: usleep: not found
>>
>> Replace it with the more standard sleep.
>>
>> Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
>> ---
>> tools/testing/selftests/ftrace/test.d/event/event-enable.tc | 6 +++---
>> tools/testing/selftests/ftrace/test.d/event/subsystem-enable.tc | 6 +++---
>> 2 files changed, 6 insertions(+), 6 deletions(-)
>>
>> diff --git a/tools/testing/selftests/ftrace/test.d/event/event-enable.tc b/tools/testing/selftests/ftrace/test.d/event/event-enable.tc
>> index 668616d9bb03..abafc0c3605c 100644
>> --- a/tools/testing/selftests/ftrace/test.d/event/event-enable.tc
>> +++ b/tools/testing/selftests/ftrace/test.d/event/event-enable.tc
>> @@ -21,7 +21,7 @@ reset_tracer
>> do_reset
>>
>> echo 'sched:sched_switch' > set_event
>> -usleep 1
>> +sleep 0.001
>
> We had patches out about this, because sleep 0.001 is not always
> supported either.
really?
In that edge case you might:
sleep .001 || sleep 1
Pádraig.
next prev parent reply other threads:[~2015-03-26 3:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-25 17:36 [PATCH] ftracetest: replace usleep by sleep Luis Henriques
2015-03-25 18:57 ` Steven Rostedt
2015-03-25 19:02 ` Luis Henriques
2015-03-25 19:51 ` Steven Rostedt
2015-03-26 0:10 ` Namhyung Kim
2015-03-26 2:50 ` Pádraig Brady [this message]
2015-03-26 13:42 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5513740A.6040500@draigBrady.com \
--to=p@draigbrady.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luis.henriques@canonical.com \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=namhyung@kernel.org \
--cc=rostedt@goodmis.org \
--cc=shuahkh@osg.samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox