linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexander Sverdlin <alexander.sverdlin@nokia.com>
To: Ioan Nicu <ioan.nicu.ext@nsn.com>,
	Peter Korsgaard <peter.korsgaard@barco.com>,
	Wolfram Sang <wsa@the-dreams.de>,
	linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Mathias Rulf <mathias.rulf@nokia.com>
Subject: Re: [PATCH] i2c: i2c-mux-gpio: Change log level to debug for probe deferrals
Date: Thu, 26 Mar 2015 10:09:51 +0100	[thread overview]
Message-ID: <5513CCDF.4090301@nokia.com> (raw)
In-Reply-To: <20150325174351.GB5209@ulegcpding.emea.nsn-net.net>

On 25/03/15 18:43, Ioan Nicu wrote:
> Probe deferral is not an error case. It happens only when
> the necessary dependencies are not there yet.
> 
> The driver core is already printing a message when a driver
> requests probe deferral, so this can be traced in the logs
> without these error prints.
> 
> This patch changes the error messages from these deferral cases
> to debug messages.
> 
> Signed-off-by: Ionut Nicu <ioan.nicu.ext@nokia.com>

Acked-by: Alexander Sverdlin <alexander.sverdlin@nokia.com>

> ---
>  drivers/i2c/muxes/i2c-mux-gpio.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/i2c/muxes/i2c-mux-gpio.c b/drivers/i2c/muxes/i2c-mux-gpio.c
> index f5798eb..9f1cfca 100644
> --- a/drivers/i2c/muxes/i2c-mux-gpio.c
> +++ b/drivers/i2c/muxes/i2c-mux-gpio.c
> @@ -77,7 +77,7 @@ static int i2c_mux_gpio_probe_dt(struct gpiomux *mux,
>         }
>         adapter = of_find_i2c_adapter_by_node(adapter_np);
>         if (!adapter) {
> -               dev_err(&pdev->dev, "Cannot find parent bus\n");
> +               dev_dbg(&pdev->dev, "Cannot find parent bus\n");
>                 return -EPROBE_DEFER;
>         }
>         mux->data.parent = i2c_adapter_id(adapter);
> @@ -178,7 +178,7 @@ static int i2c_mux_gpio_probe(struct platform_device *pdev)
>  
>         parent = i2c_get_adapter(mux->data.parent);
>         if (!parent) {
> -               dev_err(&pdev->dev, "Parent adapter (%d) not found\n",
> +               dev_dbg(&pdev->dev, "Parent adapter (%d) not found\n",
>                         mux->data.parent);
>                 return -EPROBE_DEFER;
>         }

-- 
Best regards,
Alexander Sverdlin.

  parent reply	other threads:[~2015-03-26  9:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-25 17:43 [PATCH] i2c: i2c-mux-gpio: Change log level to debug for probe deferrals Ioan Nicu
2015-03-25 19:48 ` Peter Korsgaard
2015-03-26  9:09 ` Alexander Sverdlin [this message]
2015-03-27 15:29 ` Wolfram Sang
2015-03-30  7:57   ` Ioan Nicu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5513CCDF.4090301@nokia.com \
    --to=alexander.sverdlin@nokia.com \
    --cc=ioan.nicu.ext@nsn.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathias.rulf@nokia.com \
    --cc=peter.korsgaard@barco.com \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).