From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752086AbbCZJKB (ORCPT <rfc822;w@1wt.eu>);
	Thu, 26 Mar 2015 05:10:01 -0400
Received: from demumfd001.nsn-inter.net ([93.183.12.32]:42453 "EHLO
	demumfd001.nsn-inter.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751065AbbCZJJ6 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 26 Mar 2015 05:09:58 -0400
Message-ID: <5513CCDF.4090301@nokia.com>
Date: Thu, 26 Mar 2015 10:09:51 +0100
From: Alexander Sverdlin <alexander.sverdlin@nokia.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: Ioan Nicu <ioan.nicu.ext@nsn.com>,
        Peter Korsgaard <peter.korsgaard@barco.com>,
        Wolfram Sang <wsa@the-dreams.de>, linux-i2c@vger.kernel.org,
        linux-kernel@vger.kernel.org
CC: Mathias Rulf <mathias.rulf@nokia.com>
Subject: Re: [PATCH] i2c: i2c-mux-gpio: Change log level to debug for probe
 deferrals
References: <20150325174351.GB5209@ulegcpding.emea.nsn-net.net>
In-Reply-To: <20150325174351.GB5209@ulegcpding.emea.nsn-net.net>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-purgate-type: clean
X-purgate-Ad: Categorized by eleven eXpurgate (R) http://www.eleven.de
X-purgate: clean
X-purgate: This mail is considered clean (visit http://www.eleven.de for further information)
X-purgate-size: 1720
X-purgate-ID: 151667::1427360994-00005972-FF45D01D/0/0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 25/03/15 18:43, Ioan Nicu wrote:
> Probe deferral is not an error case. It happens only when
> the necessary dependencies are not there yet.
> 
> The driver core is already printing a message when a driver
> requests probe deferral, so this can be traced in the logs
> without these error prints.
> 
> This patch changes the error messages from these deferral cases
> to debug messages.
> 
> Signed-off-by: Ionut Nicu <ioan.nicu.ext@nokia.com>

Acked-by: Alexander Sverdlin <alexander.sverdlin@nokia.com>

> ---
>  drivers/i2c/muxes/i2c-mux-gpio.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/i2c/muxes/i2c-mux-gpio.c b/drivers/i2c/muxes/i2c-mux-gpio.c
> index f5798eb..9f1cfca 100644
> --- a/drivers/i2c/muxes/i2c-mux-gpio.c
> +++ b/drivers/i2c/muxes/i2c-mux-gpio.c
> @@ -77,7 +77,7 @@ static int i2c_mux_gpio_probe_dt(struct gpiomux *mux,
>         }
>         adapter = of_find_i2c_adapter_by_node(adapter_np);
>         if (!adapter) {
> -               dev_err(&pdev->dev, "Cannot find parent bus\n");
> +               dev_dbg(&pdev->dev, "Cannot find parent bus\n");
>                 return -EPROBE_DEFER;
>         }
>         mux->data.parent = i2c_adapter_id(adapter);
> @@ -178,7 +178,7 @@ static int i2c_mux_gpio_probe(struct platform_device *pdev)
>  
>         parent = i2c_get_adapter(mux->data.parent);
>         if (!parent) {
> -               dev_err(&pdev->dev, "Parent adapter (%d) not found\n",
> +               dev_dbg(&pdev->dev, "Parent adapter (%d) not found\n",
>                         mux->data.parent);
>                 return -EPROBE_DEFER;
>         }

-- 
Best regards,
Alexander Sverdlin.