From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752197AbbCZJYV (ORCPT ); Thu, 26 Mar 2015 05:24:21 -0400 Received: from mailapp01.imgtec.com ([195.59.15.196]:33060 "EHLO imgpgp01.kl.imgtec.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751701AbbCZJYR (ORCPT ); Thu, 26 Mar 2015 05:24:17 -0400 X-PGP-Universal: processed; by imgpgp01.kl.imgtec.org on Thu, 26 Mar 2015 09:24:15 +0000 Message-ID: <5513D037.40003@imgtec.com> Date: Thu, 26 Mar 2015 09:24:07 +0000 From: James Hogan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Greg Kroah-Hartman CC: Ralf Baechle , , Subject: Re: [PATCH v3 2/3] MIPS: Add CDMM bus support References: <20150325123756.GA2200@kroah.com> <1427297990-14023-1-git-send-email-james.hogan@imgtec.com> <20150325220339.GC10513@kroah.com> In-Reply-To: <20150325220339.GC10513@kroah.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="FFRhi57dN3j7HTnhB6EWF4iOhkMjW5upk" X-Originating-IP: [192.168.154.110] X-ESG-ENCRYPT-TAG: da4c5968 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --FFRhi57dN3j7HTnhB6EWF4iOhkMjW5upk Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 25/03/15 22:03, Greg Kroah-Hartman wrote: > On Wed, Mar 25, 2015 at 03:39:50PM +0000, James Hogan wrote: >> Add MIPS Common Device Memory Map (CDMM) support in the form of a bus = in >> the standard Linux device model. Each device attached via CDMM is >> discoverable via an 8-bit type identifier and may contain a number of >> blocks of memory mapped registers in the CDMM region. IRQs are expecte= d >> to be handled separately. >> >> Due to the per-cpu (per-VPE for MT cores) nature of the CDMM devices, >> all the driver callbacks take place from workqueues which are run on t= he >> right CPU for the device in question, so that the driver doesn't need = to >> be as concerned about which CPU it is running on. Callbacks also exist= >> for when CPUs are taken offline, so that any per-CPU resources used by= >> the driver can be disabled so they don't get forcefully migrated. CDMM= >> devices are created as children of the CPU device they are attached to= =2E >> >> Any existing CDMM configuration by the bootloader will be inherited, >> however platforms wishing to enable CDMM should implement the weak >> mips_cdmm_phys_base() function (see asm/cdmm.h) so that the bus driver= >> knows where it should put the CDMM region in the physical address spac= e >> if the bootloader hasn't already enabled it. >> >> A mips_cdmm_early_probe() function is also provided to allow early boo= t >> or particularly low level code to set up the CDMM region and probe for= a >> specific device type, for example early console or KGDB IO drivers for= >> the EJTAG Fast Debug Channel (FDC) CDMM device. >> >> Signed-off-by: James Hogan >> Cc: Ralf Baechle >> Cc: Greg Kroah-Hartman >> Cc: linux-mips@linux-mips.org >> --- >> Changes in v3: >> - Convert to use dev_groups rather than dev_attrs (GregKH). >> - Rename mips_cdmm_attr_func() macro to CDMM_ATTR for consistency with= >> other similar macro names I've seen around the kernel. >> - Add modalias attribute. >> >> Changes in v2: >> - Fix some checkpatch errors. >> - Correct CDMM name in various places. It is "Common Device Memory Map= ", >> rather than "Common Device Mapped Memory" (which for some reason had= >> got stuck in my head). >> --- >> arch/mips/include/asm/cdmm.h | 87 +++++ >> drivers/bus/Kconfig | 13 + >> drivers/bus/Makefile | 1 + >> drivers/bus/mips_cdmm.c | 716 +++++++++++++++++++++++++++++= +++++++++ >> include/linux/mod_devicetable.h | 8 + >> scripts/mod/devicetable-offsets.c | 3 + >> scripts/mod/file2alias.c | 16 + >> 7 files changed, 844 insertions(+) >> create mode 100644 arch/mips/include/asm/cdmm.h >> create mode 100644 drivers/bus/mips_cdmm.c >=20 > Acked-by: Greg Kroah-Hartman Thanks Greg! Cheers James --FFRhi57dN3j7HTnhB6EWF4iOhkMjW5upk Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJVE9A+AAoJEGwLaZPeOHZ61owP/jiNaOEHXobzN7jChahM0XOs OkfFaBB5EbrYpZmhR/w2VF4ieQFKRxDDI/7A/AI5i40C0Sy3tyekDVvLh+zIJPo8 EmA+5gQY7Jnzu/ZaR0QaagtEwJEHnZtGsSjT7dxaijtqhn/9rQbhA+hQrgQabhCz 2iPQDrCflv4rJAItUAxXQ+kiPtdePNOvYxxzImoPjR/NhazxAKZ0OrY2Ct2iX4Bu nTqErjq4y9spBJ5jxbWQy2z49THjC1xjFO2L3n15jBGOxnCREMrFlGHKulxx9C08 g5IedJ6bh2vUg2kF+aEB3S5D4GmYW/aiow47/ut4IaZ6OGlm09N770fvrwf1rwa+ qaS9XzT9kXswlKVagsNsm4sNiDDfnm90L0xUNMlNrhD8XtpTysq8EzQde6oFSoNw cq4Rp9Z6ItDN5VyndgAmsT5Z+TvDGFSv/GjPe2k59l8Al+BvvZdxWFsqcG17Mqi0 e0VRMtI6ampr7SvlBXMGaI1C6XNsfLyihLD/HkJVGFtAVCUJTTFa8GyClA41I3Of b+LBpfA4McRK/ZrmSdAzwi71ldIoCjF1JPO4kQ3JPLrkSrmRcw2BqLclBxzyn9/S olox834sSvDY5rsYUt+Yv4E9H9k1h1s2V4ZGCd2FelFpm1ttI0iTYKm1lHQS2+dS pOAt28LJBPR+E4dPRw7u =G8Ce -----END PGP SIGNATURE----- --FFRhi57dN3j7HTnhB6EWF4iOhkMjW5upk--