From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752403AbbCZJwp (ORCPT ); Thu, 26 Mar 2015 05:52:45 -0400 Received: from mail-wi0-f178.google.com ([209.85.212.178]:33756 "EHLO mail-wi0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752363AbbCZJwk (ORCPT ); Thu, 26 Mar 2015 05:52:40 -0400 Message-ID: <5513D6E4.4000101@linaro.org> Date: Thu, 26 Mar 2015 10:52:36 +0100 From: Daniel Lezcano User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Markos Chandras , linux-mips@linux-mips.org CC: Thomas Gleixner , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] clocksource: mips-gic-timer: Ensure GIC counter is running References: <1427113923-9840-1-git-send-email-markos.chandras@imgtec.com> <1427113923-9840-3-git-send-email-markos.chandras@imgtec.com> In-Reply-To: <1427113923-9840-3-git-send-email-markos.chandras@imgtec.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/23/2015 01:32 PM, Markos Chandras wrote: > Start the GIC counter after configuring the clocksource since there > are no guarantees the counter will be running after a CPU reset. > > Cc: Daniel Lezcano > Cc: Thomas Gleixner > Cc: > Signed-off-by: Markos Chandras Acked-by: Daniel Lezcano > --- > drivers/clocksource/mips-gic-timer.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/clocksource/mips-gic-timer.c b/drivers/clocksource/mips-gic-timer.c > index 3bd31b1321f6..16adbc1fa4c1 100644 > --- a/drivers/clocksource/mips-gic-timer.c > +++ b/drivers/clocksource/mips-gic-timer.c > @@ -133,6 +133,9 @@ static void __init __gic_clocksource_init(void) > clocksource_register_hz(&gic_clocksource, gic_frequency); > > gic_clockevent_init(); > + > + /* And finally start the counter */ > + gic_start_count(); > } > > void __init gic_clocksource_init(unsigned int frequency) > -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog