From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752480AbbCZKMR (ORCPT ); Thu, 26 Mar 2015 06:12:17 -0400 Received: from mga03.intel.com ([134.134.136.65]:52695 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752443AbbCZKMN (ORCPT ); Thu, 26 Mar 2015 06:12:13 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,470,1422950400"; d="scan'208";a="685923327" Message-ID: <5513DBB8.5010900@intel.com> Date: Thu, 26 Mar 2015 12:13:12 +0200 From: Daniel Baluta User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Paul Bolle CC: jic23@kernel.org, jlbec@evilplan.org, lars@metafoo.de, knaack.h@gmx.de, pmeerw@pmeerw.net, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, octavian.purdila@intel.com Subject: Re: [PATCH 1/3] iio: configfs: Add configfs support to IIO References: <1427302832-9336-1-git-send-email-daniel.baluta@intel.com> <1427302832-9336-2-git-send-email-daniel.baluta@intel.com> <1427314499.10958.36.camel@x220> In-Reply-To: <1427314499.10958.36.camel@x220> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/25/2015 10:14 PM, Paul Bolle wrote: > A license nit. > > On Wed, 2015-03-25 at 19:00 +0200, Daniel Baluta wrote: >> --- /dev/null >> +++ b/drivers/iio/industrialio-configfs.c > >> + * This program is free software; you can redistribute it and/or modify it >> + * under the terms of the GNU General Public License version 2 as published by >> + * the Free Software Foundation. > >> +MODULE_AUTHOR("Daniel Baluta "); >> +MODULE_DESCRIPTION("Industrial I/O configfs support"); > > You probably want > MODULE_LICENSE("GPL v2"); > > here too. Because now, at module load time, the license will default to > "unspecified" which will taint the kernel. :), correct! I forgot about it. Daniel.