From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752212AbbCZMdh (ORCPT ); Thu, 26 Mar 2015 08:33:37 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:60200 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751797AbbCZMdf (ORCPT ); Thu, 26 Mar 2015 08:33:35 -0400 Message-ID: <5513FC7A.7090708@ti.com> Date: Thu, 26 Mar 2015 14:32:58 +0200 From: Peter Ujfalusi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Vinod Koul CC: , , , , , , , , , Subject: Re: [PATCH v2 4/7] dmaengine: omap-dma: Use defines for dma channels and request count References: <1426080210-841-1-git-send-email-peter.ujfalusi@ti.com> <1426080210-841-5-git-send-email-peter.ujfalusi@ti.com> <20150326105712.GL32683@intel.com> In-Reply-To: <20150326105712.GL32683@intel.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/26/2015 12:57 PM, Vinod Koul wrote: > On Wed, Mar 11, 2015 at 03:23:27PM +0200, Peter Ujfalusi wrote: >> Instead of magic numbers in the code, use define for number of logical DMA >> channels and DMA requests. >> >> Signed-off-by: Peter Ujfalusi >> --- >> drivers/dma/omap-dma.c | 7 +++++-- >> 1 file changed, 5 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/dma/omap-dma.c b/drivers/dma/omap-dma.c >> index 7dd6dd121681..56c33e93dd24 100644 >> --- a/drivers/dma/omap-dma.c >> +++ b/drivers/dma/omap-dma.c >> @@ -22,6 +22,9 @@ >> >> #include "virt-dma.h" >> >> +#define OMAP_SDMA_REQUESTS 127 >> +#define OMAP_SDMA_CHANNELS 32 > Again why dont we put these things in DT ? They are in DT, the next patch will take the needed information from there and uses these values as fallback values in case they are missing for some reason. -- Péter