From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752830AbbCZNZ7 (ORCPT ); Thu, 26 Mar 2015 09:25:59 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:12042 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752081AbbCZNZz (ORCPT ); Thu, 26 Mar 2015 09:25:55 -0400 X-AuditID: cbfee68f-f791c6d000004834-ef-551408e1318e Message-id: <551408E0.3060901@samsung.com> Date: Thu, 26 Mar 2015 22:25:52 +0900 From: Beomho Seo User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-version: 1.0 To: Lee Jones Cc: Krzysztof Kozlowski , Sebastian Reichel , Jaewon Kim , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux-input@vger.kernel.org, Inki Dae , SangBae Lee , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Chanwoo Choi , Dmitry Torokhov Subject: Re: [PATCH v7 2/5] power: max77843_charger: Add Max77843 charger device driver References: <1425291038-18269-1-git-send-email-jaewon02.kim@samsung.com> <1425291038-18269-3-git-send-email-jaewon02.kim@samsung.com> <20150307201340.GF5233@earth> <54FCEABE.9000007@samsung.com> <54FD880E.30903@samsung.com> <1425903199.13415.9.camel@AMDC1943> <54FEF541.6000305@samsung.com> <551119DE.2070402@samsung.com> In-reply-to: Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrIIsWRmVeSWpSXmKPExsWyRsSkUPchh0ioQedMAYvrX56zWsw/co7V 4vCiF4wW/W8Wslqce7WS0WLS/QksFjsajrBavH5haHH/61FGi5ufvrFaXN41h83ic+8RRoul 1y8yWUyYvpbFonXvEXaL458Oslic3l3iIOixZt4aRo/Lfb1MHjtn3WX3WLn8C5vHplWdbB53 ru1h8+jbsorR4/MmuQCOKC6blNSczLLUIn27BK6MI0tnMRVcV6p4deM+UwPjSZkuRk4OCQET iXWHnrNB2GISF+6tB7K5OIQEljJKbJjTygJT1DL/IyNEYhGjxI6NXVDOA0aJyc9Wg1XxCmhJ 3Gr9AGazCKhKTH/VxAxiswloSryfcgUozsEhKhAhcfsyJ0S5oMSPyffAwiICKhLn3piDjGQW uMoisWrDZ7CLhAUiJSZuuw510XVmiRMv14MlOAWCJbY2PmADaWYWUJeYMiUXJMwsIC+xec1b ZpB6CYG1HBJPH/ezQtwjIPFt8iGwZRICshKbDjBDPCYpcXDFDZYJjGKzkJw0C2HqLCRTFzAy r2IUTS1ILihOSi8y1itOzC0uzUvXS87P3cQIjPnT/57172C8e8D6EKMAB6MSD++PfuFQIdbE suLK3EOMpkBHTGSWEk3OByaWvJJ4Q2MzIwtTE1NjI3NLMyVx3oVSP4OFBNITS1KzU1MLUovi i0pzUosPMTJxcEo1MPatPrk0rq64xSAnyznF3CwhYWP5uj9F26pvO2205NJL+1qg8uxjmPfm RzprS2Tm3WzcxJTJk/2+8mRrRuRTd4to7312eW8rc97/f8H+xHLZjhO2HXueyynZ7IjLZvy8 kO+K8RK+t8vyV09k+PnaYorR5cfLLq77P/vd78llC1gLnswufrpxUbQSS3FGoqEWc1FxIgAR efVY9AIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrNKsWRmVeSWpSXmKPExsVy+t9jAd2HHCKhBjdmsVlc//Kc1WL+kXOs FocXvWC06H+zkNXi3KuVjBaT7k9gsdjRcITV4vULQ4v7X48yWtz89I3V4vKuOWwWn3uPMFos vX6RyWLC9LUsFq17j7BbHP90kMXi9O4SB0GPNfPWMHpc7utl8tg56y67x8rlX9g8Nq3qZPO4 c20Pm0ffllWMHp83yQVwRDUw2mSkJqakFimk5iXnp2TmpdsqeQfHO8ebmhkY6hpaWpgrKeQl 5qbaKrn4BOi6ZeYAvaGkUJaYUwoUCkgsLlbSt8M0ITTETdcCpjFC1zckCK7HyAANJKxhzDiy dBZTwXWlilc37jM1MJ6U6WLk5JAQMJFomf+REcIWk7hwbz1bFyMXh5DAIkaJHRu7GCGcB4wS k5+tZgGp4hXQkrjV+gHMZhFQlZj+qokZxGYT0JR4P+UKUJyDQ1QgQuL2ZU6IckGJH5PvgYVF BFQkzr0xBxnJLHCVRWLVhs9sIDXCApESE7ddh1p8nVnixMv1YAlOgWCJrY0P2ECamQXUJaZM yQUJMwvIS2xe85Z5AqPALCQrZiFUzUJStYCReRWjaGpBckFxUnquoV5xYm5xaV66XnJ+7iZG cEJ5JrWDcWWDxSFGAQ5GJR7eH/3CoUKsiWXFlbmHGCU4mJVEeHcwiIQK8aYkVlalFuXHF5Xm pBYfYjQF+n8is5Rocj4w2eWVxBsam5gZWRqZG1oYGZsrifMq2beFCAmkJ5akZqemFqQWwfQx cXBKNTA2CB9kKZW0VTpmmRA2V6875Z3wp60r/25xYU252fTFzkvKQHb39MNrOXfE1uw8cVGn WfrscrPMY0oOm5Q7GK2tf27hFreQfXDjM0eKXEDitDU1gjkc0xN+y0Ww69hejjXjv7PlTZ1C nJb9tuMfI1vixZ3OGVTdevPCcLNkive0qrDT1fu1zyixFGckGmoxFxUnAgAPsb1FPgMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/24/2015 05:38 PM, Krzysztof Kozlowski wrote: > 2015-03-24 9:01 GMT+01:00 Beomho Seo : >> On 03/10/2015 10:44 PM, Beomho Seo wrote: >>> On 03/09/2015 09:13 PM, Krzysztof Kozlowski wrote: >>>> On pon, 2015-03-09 at 20:46 +0900, Beomho Seo wrote: >>>>> On 03/09/2015 08:02 PM, Krzysztof Kozlowski wrote: >>>>>> 2015-03-09 1:35 GMT+01:00 Beomho Seo : >>>>>>> On 03/08/2015 05:13 AM, Sebastian Reichel wrote: >>>>>>>> On Mon, Mar 02, 2015 at 07:10:35PM +0900, Jaewon Kim wrote: >>>>>>>>> From: Beomho Seo >>>>>>>>> >>>>>>>>> This patch adds device driver of max77843 charger. This driver provide >>>>>>>>> initialize each charging mode(e.g. fast charge, top-off mode and constant >>>>>>>>> charging mode so on.). Additionally, control charging paramters to use >>>>>>>>> i2c interface. >>>>>>>>> >>>>>>>>> Cc: Sebastian Reichel >>>>>>>>> Signed-off-by: Beomho Seo >>>>>>>> >>>>>>>> Reviewed-By: Sebastian Reichel >>>>>>>> >>>>>>>> I can't take it as is, since it depends on the private header file >>>>>>>> of PATCHv1. >>>>>>>> >>>>>>>> -- Sebastian >>>>>>>> >>>>>>> >>>>>>> This patch reviewed by Sebastian. >>>>>>> Could you Please merge that your git tree ? >>>>>> >>>>>> Hi, >>>>>> >>>>>> ... and again we are adding a new driver for very similar chipset to >>>>>> already supported. I looked at spec and the charger's registers are >>>>>> almost the same as for max77693. Their layout and addresses are the >>>>>> same. I see some minor differences, probably the most important would >>>>>> be different values current (fast-charge, top-off). But still 90% of >>>>>> registers are the same... Do we really have to add new driver? >>>>>> >>>>>> Best regards, >>>>>> Krzysztof >>>>>> -- >>>>>> To unsubscribe from this list: send the line "unsubscribe linux-input" in >>>>>> the body of a message to majordomo@vger.kernel.org >>>>>> More majordomo info at http://vger.kernel.org/majordomo-info.html >>>>>> >>>>> >>>>> Hi, >>>>> >>>>> Thank you for your comment. As you say, both chip set are similar. >>>>> But new driver need for support max77843. It is support different below >>>>> - Provide Battery presence information. >>>> >>>> Another set of power supply properties could be added for that chip. >>>> This way the get_property() function would be the same but actually the >>>> POWER_SUPPLY_PROP_PRESENT won't be called for max77693. >>>> >>>>> - Can OTG FET control. >>>> >>>> Where the OTG FET feature is it enabled in your driver? I couldn't find >>>> it. >>>> >>> >>> Sorry. This driver don't control OTG FET feature. >>> >>>>> - Bigger Fast charge current, Top Off current Threshold selection. >>>>> - Various and bigger OTG current limitation. >>>>> - Bigger primary charger termination voltage setting. >>>>> - Different maximum input current limit selection(Different step). >>>> >>>> Yes, I mentioned some of these differences (the Fast/top-off >>>> differences). These are differences in values so it does not require new >>>> driver. There is need to develop new driver just to support different >>>> current (3.0 A instead of 2.1 A) or voltage threshold. >>>> >>> >>> They are different charging current, OTG current limitation, top off current, >>> charging limitation value. In case OTG current limitation different not >>> limitation value but using register bit(max77843 use[7:6] max77693 use[7] >>> bit only). Even if this driver not support all feature, some register >>> different with max77693(support value, use register bit). >>> >>> If this driver will combined with max77693 may even be beneficial for >>> new Maxim driver. But the present, this driver is related with >>> max77843 core driver and max77843-regulator. So I hope this driver >>> merge first. And then will extend two driver(max77843 charger and max77693 charger). > > I still prefer merging common drivers into one instead of creating > some more of them. > However I understand your point and I am not entirely opposed against. > Especially that you invested quite a bit of time for developing this > and my feedback was quite late. To summarize I am fine with your > approach. > > Best regards, > Krzysztof > Dear Lee Jones, Could you please merge that your git tree ? Best regards, Beomho Seo