public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jslaby@suse.cz>,
	Robert Baldyga <r.baldyga@samsung.com>,
	Sylwester Nawrocki <s.nawrocki@samsung.com>,
	Olof Johansson <olof@lixom.net>,
	Doug Anderson <dianders@chromium.org>,
	linux-samsung-soc@vger.kernel.org, linux-serial@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] serial: samsung: Clear operation mode on UART shutdown
Date: Thu, 26 Mar 2015 23:19:20 +0100	[thread overview]
Message-ID: <551485E8.2050406@collabora.co.uk> (raw)
In-Reply-To: <20150326215719.GA13985@kroah.com>

On 03/26/2015 10:57 PM, Greg Kroah-Hartman wrote:
> On Fri, Mar 20, 2015 at 01:19:44PM +0100, Javier Martinez Canillas wrote:
>> > The offending commit landed in v4.0-rc1 so this fix is -rc material.
>> > 
>> >  drivers/tty/serial/samsung.c | 1 +
>> >  1 file changed, 1 insertion(+)
>> > 
>> > diff --git a/drivers/tty/serial/samsung.c b/drivers/tty/serial/samsung.c
>> > index af821a908720..cf08876922f1 100644
>> > --- a/drivers/tty/serial/samsung.c
>> > +++ b/drivers/tty/serial/samsung.c
>> > @@ -963,6 +963,7 @@ static void s3c24xx_serial_shutdown(struct uart_port *port)
>> >  			free_irq(ourport->tx_irq, ourport);
>> >  		tx_enabled(port) = 0;
>> >  		ourport->tx_claimed = 0;
>> > +		ourport->tx_mode = 0;
>> >  	}
>> >  
>> >  	if (ourport->rx_claimed) {
>> > 
>> 
>> Any comments about this patch? 3.14-rc5 will most likely be released this weekend
>> so we are running out of time to fix this issue before 3.14 is released.
> 
> 3.14 was released months ago...
> 

err... I don't know what I was thinking when I wrote this, I obviously
meant 4.0. It seems the 3.1 prefix stuck in my head :)

Best regards,
Javier

  reply	other threads:[~2015-03-26 22:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-13 11:38 [PATCH 1/1] serial: samsung: Clear operation mode on UART shutdown Javier Martinez Canillas
2015-03-20 12:19 ` Javier Martinez Canillas
2015-03-26 21:57   ` Greg Kroah-Hartman
2015-03-26 22:19     ` Javier Martinez Canillas [this message]
2015-03-20 13:34 ` Sylwester Nawrocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=551485E8.2050406@collabora.co.uk \
    --to=javier.martinez@collabora.co.uk \
    --cc=dianders@chromium.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=olof@lixom.net \
    --cc=r.baldyga@samsung.com \
    --cc=s.nawrocki@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox