From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751189AbbC0EBv (ORCPT ); Fri, 27 Mar 2015 00:01:51 -0400 Received: from szxga01-in.huawei.com ([58.251.152.64]:28406 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750715AbbC0EBu (ORCPT ); Fri, 27 Mar 2015 00:01:50 -0400 Message-ID: <5514D617.6080100@huawei.com> Date: Fri, 27 Mar 2015 12:01:27 +0800 From: "Chentao (Boby)" User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: =?windows-1252?Q?Roger_Pau_Monn=E9?= , CC: , , , Subject: Re: [PATCH] xen-blkback: enlarge the array size of blkback name References: <1426261941-32424-1-git-send-email-boby.chen@huawei.com> <5513EC1E.5090601@citrix.com> In-Reply-To: <5513EC1E.5090601@citrix.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.177.25.98] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org You are right, roger. Thanks. domid is a u16, it will occupy 5 characters at most. So the biggest length of blkback name is 8+5+5=18. At this situation, define BLKBACK_NAME_LEN macro to be 20 is safe. On 2015/3/26 19:23, Roger Pau Monné wrote: > El 13/03/15 a les 16.52, Tao Chen ha escrit: >> The blkback name is like blkback.domid.xvd[a-z], if domid has three digits >> (means larger than 100), then the backmost xvd wouldn't be fully shown. >> >> Define a BLKBACK_NAME_LEN macro which is (TASK_COMM_LEN * 2), enlarge the >> array size of blkback name, so it will be fully shown in any case. >> >> Signed-off-by: Tao Chen >> --- >> drivers/block/xen-blkback/xenbus.c | 7 +++++-- >> 1 file changed, 5 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/block/xen-blkback/xenbus.c b/drivers/block/xen-blkback/xenbus.c >> index e3afe97..0289e21 100644 >> --- a/drivers/block/xen-blkback/xenbus.c >> +++ b/drivers/block/xen-blkback/xenbus.c >> @@ -21,6 +21,9 @@ >> #include >> #include "common.h" >> >> +/* Enlarge the array size in order to fully show blkback name. */ >> +#define BLKBACK_NAME_LEN (TASK_COMM_LEN * 2) > > Any reason to use TASK_COMM_LEN instead of just coding it to 17? Or > maybe 20 to be on the safe side? > > Roger. > > . >