From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752902AbbC0Fzf (ORCPT ); Fri, 27 Mar 2015 01:55:35 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:9017 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752683AbbC0Fz2 (ORCPT ); Fri, 27 Mar 2015 01:55:28 -0400 X-AuditID: cbfee691-f79b86d000004a5a-76-5514f0c62eda Message-id: <5514F0C5.7080509@samsung.com> Date: Fri, 27 Mar 2015 14:55:17 +0900 From: Jaehoon Chung User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-version: 1.0 To: Doug Anderson , Ulf Hansson , Heiko Stuebner , Seungwon Jeon Cc: Mark Brown , Alexandru Stan , Alim Akhtar , Sonny Rao , Andrew Bresticker , Addy Ke , javier.martinez@collabora.co.uk, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, chris@printf.net, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 1/4] mmc: dw_mmc: Don't try to enable the CD until we're sure we're not deferring References: <1426112117-18220-1-git-send-email-dianders@chromium.org> In-reply-to: <1426112117-18220-1-git-send-email-dianders@chromium.org> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrCIsWRmVeSWpSXmKPExsWyRsSkUPfYB5FQgz+beC1Wvv/LaLHs/3cm iwfztrFZNLyYxGox9eETNosJl7czWpxddpDN4v+j16wWR38XWGx6fI3V4vKuOWwWR/73M1p8 evCf2eLJmZmMFh/uX2S2OL423EHAY3bDRRaPv8+vs3hsWtXJ5nHn2h42j81L6j1uvFrI5PF3 1n4Wj74tqxg9tl+bx+zxeZNcAFcUl01Kak5mWWqRvl0CV0b3v4csBasEKi5+Xc3awPiNp4uR k0NCwERi8qo1bBC2mMSFe+uBbC4OIYGljBI7+56zdjFygBWdfZEAEZ/OKLFv6lxWCOcBo8Te julg3bwCWhKzXyxjArFZBFQlpi7aD2azCehIbP92HMwWFQiTmHjzMStEvaDEj8n3WEAGiQjM ZpT4Mf8AE4jDLLCAWeLmoxmMIFXCAlkS016/ZAM5Q0jAVeLW2xAQk1PATWLxegsQk1lAT+L+ RS2QYmYBeYnNa94yg0yRENjDIXFp9j12iHsEJL5NPsQC8YysxKYDzBAPS0ocXHGDZQKj2Cwk F81CmDoLydQFjMyrGEVTC5ILipPSi0z1ihNzi0vz0vWS83M3MQIj//S/ZxN3MN4/YH2IUYCD UYmH98dukVAh1sSy4srcQ4ymQEdMZJYSTc4Hppe8knhDYzMjC1MTU2Mjc0szJXFeHemfwUIC 6YklqdmpqQWpRfFFpTmpxYcYmTg4pRoYFZOfMi5JFTv//Z9B6cfKgsu6Qclau3r+16fZNbcm fHj0YN+P0h8dCTsPCvheq339h/186IFOc/U52arRAQrMXWeu2vmllF66f21flOrOhjf+TLkn nx6b26IoGOo/70dccNvuRGYugQbrl8cmuhsZB3vzCcf4sXyO4Uy8mKGjlvNCSJDjbb4SS3FG oqEWc1FxIgAjaZGz9wIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrHKsWRmVeSWpSXmKPExsVy+t9jQd1jH0RCDRaeZrFY+f4vo8Wy/9+Z LB7M28Zm0fBiEqvF1IdP2CwmXN7OaHF22UE2i/+PXrNaHP1dYLHp8TVWi8u75rBZHPnfz2jx 6cF/ZosnZ2YyWny4f5HZ4vjacAcBj9kNF1k8/j6/zuKxaVUnm8eda3vYPDYvqfe48Wohk8ff WftZPPq2rGL02H5tHrPH501yAVxRDYw2GamJKalFCql5yfkpmXnptkrewfHO8aZmBoa6hpYW 5koKeYm5qbZKLj4Bum6ZOUCvKCmUJeaUAoUCEouLlfTtME0IDXHTtYBpjND1DQmC6zEyQAMJ axgzuv89ZClYJVBx8etq1gbGbzxdjBwcEgImEmdfJHQxcgKZYhIX7q1n62Lk4hASmM4osW/q XFYI5wGjxN6O6WwgVbwCWhKzXyxjArFZBFQlpi7aD2azCehIbP92HMwWFQiTmHjzMStEvaDE j8n3WEAGiQjMZpT4Mf8AE4jDLLCAWeLmoxmMIFXCAlkS016/ZAM5SUjAVeLW2xAQk1PATWLx egsQk1lAT+L+RS2QYmYBeYnNa94yT2AUmIVkwyyEqllIqhYwMq9iFE0tSC4oTkrPNdIrTswt Ls1L10vOz93ECE4rz6R3MK5qsDjEKMDBqMTD+2O3SKgQa2JZcWXuIUYJDmYlEd6Vj4FCvCmJ lVWpRfnxRaU5qcWHGE2B/p/ILCWanA9MeXkl8YbGJmZGlkbmhhZGxuZK4rxK9m0hQgLpiSWp 2ampBalFMH1MHJxSDYyzlyVYB5255bPzbM7UpOaHb39x/LKJ1KuUVHU6t9Wlb/6Buh2LFjV+ 3CZx+6pmVd/kxW+839la+C6w8dl0znhC9M5w6ytCcycs6j+waprrUadfQXMeGpcsPL4/9umx wGtn1MRulvps6re/FaFoEnuwW+GM98Y9twrs1F5ZHzZ4HhIkLePavkBAiaU4I9FQi7moOBEA xGWl3UEDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Doug. This patch is not related with [patch 2/4~4/4]. "[PATCH v4 2/4] mmc: core: Add mmc_regulator_set_vqmmc()" is discussing.. So i think if you're ok, i will pick this one [PATCH v4 1/4]. how about? Best Regards, Jaehoon Chung On 03/12/2015 07:15 AM, Doug Anderson wrote: > If dw_mci_init_slot() returns that we got a probe deferral then it may > leave slot->mmc as NULL. That will cause dw_mci_enable_cd() to crash > when it calls mmc_gpio_get_cd(). > > Fix this by moving the call of dw_mci_enable_cd() until we're sure > that we're good. Note that if we have more than one slot and one > defers (but the others don't) things won't work so well. ...but > that's not a new thing and everyone has already agreed that multislot > support ought to be removed from dw_mmc eventually anyway since it is > unused, untested, and you can see several bugs like this by inspecting > the code. > > Fixes: bcafaf5470f0 ("mmc: dw_mmc: Only enable CD after setup and only if needed") > Signed-off-by: Doug Anderson > --- > Changes in v4: > - Defer vs. card detect fix patch new for v4. > > Changes in v3: None > Changes in v2: None > > drivers/mmc/host/dw_mmc.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c > index 47dfd0e..e2811cf 100644 > --- a/drivers/mmc/host/dw_mmc.c > +++ b/drivers/mmc/host/dw_mmc.c > @@ -2863,9 +2863,6 @@ int dw_mci_probe(struct dw_mci *host) > init_slots++; > } > > - /* Now that slots are all setup, we can enable card detect */ > - dw_mci_enable_cd(host); > - > if (init_slots) { > dev_info(host->dev, "%d slots initialized\n", init_slots); > } else { > @@ -2874,6 +2871,9 @@ int dw_mci_probe(struct dw_mci *host) > goto err_dmaunmap; > } > > + /* Now that slots are all setup, we can enable card detect */ > + dw_mci_enable_cd(host); > + > if (host->quirks & DW_MCI_QUIRK_IDMAC_DTO) > dev_info(host->dev, "Internal DMAC interrupt fix enabled.\n"); > >