From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752691AbbC0HVP (ORCPT ); Fri, 27 Mar 2015 03:21:15 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:56539 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751823AbbC0HVM (ORCPT ); Fri, 27 Mar 2015 03:21:12 -0400 X-AuditID: cbfee691-f79b86d000004a5a-65-551504e65c7b Message-id: <551504E5.7060304@samsung.com> Date: Fri, 27 Mar 2015 16:21:09 +0900 From: Jaehoon Chung User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-version: 1.0 To: Doug Anderson , Alim Akhtar Cc: Seungwon Jeon , Ulf Hansson , Alim Akhtar , Sonny Rao , Andrew Bresticker , Heiko Stuebner , Addy Ke , Alexandru Stan , Javier Martinez Canillas , "linux-arm-kernel@lists.infradead.org" , "open list:ARM/Rockchip SoC..." , Chris Ball , "linux-mmc@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] mmc: dw_mmc: Don't send clock off command if power is off References: <1426874420-25103-1-git-send-email-dianders@chromium.org> In-reply-to: Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrKIsWRmVeSWpSXmKPExsWyRsSkQPcZi2iowbevXBYr3/9ltFj2/zuT xdJb1RYP5m1js2h4MYnVYsLl7YwWZ5cdZLP4/+g1q8XR3wUWmx5fY7W4vGsOm8WR//2MFp8e /Ge2eHJmJqPFh/sXmS2Orw13EPCY3XCRxePv8+ssHjtn3WX3uHNtD5vH5iX1HjdeLWTy+Dtr P4tH35ZVjB7br81j9vi8SS6AK4rLJiU1J7MstUjfLoErY2PrBqaCG1wVuz/eYG9gfMXexcjJ ISFgIvGv9w0zhC0mceHeerYuRi4OIYGljBKLJk1nhCmasOQlO0RiOqPEwUlHWCGcB4wSD18t A6viFdCSuDZ3PdhYFgFVidd3V4LF2QR0JLZ/O84EYosKhElMvPmYFaJeUOLH5HssILaIgJ/E n1/fWUCGMgssZ5V4Mm8NWLMwUKL57C5miG2XGSXudS8Dcjg4OAWCJZ6sUwMxmQXUJaZMyQUp ZxaQl9i85i1YuYTAFg6Jk7uWQh0kIPFt8iEWkHoJAVmJTQegXpaUOLjiBssERrFZSE6ahTB1 FpKpCxiZVzGKphYkFxQnpReZ6hUn5haX5qXrJefnbmIExv7pf88m7mC8f8D6EKMAB6MSD++P 3SKhQqyJZcWVuYcYTYGOmMgsJZqcD0wweSXxhsZmRhamJqbGRuaWZkrivDrSP4OFBNITS1Kz U1MLUovii0pzUosPMTJxcEo1MCbnPG8T/P2tYqpC4kWPnOxG23NPmva96/x4zlJV/ragqVrm rcsiakb2gjclaja3fbilwFHq9dKpk7OT7UaB2WPXlllOJqGXZ3/yaeJe/2LaDv1HfituWP0+ fE/ivv/xw8cVs3oe7dhqZ3Ces+5bQLFelkSpz4zpjzWDmgu+P/Q6d7Aq8Wv3VSWW4oxEQy3m ouJEAPaiHgT4AgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrPKsWRmVeSWpSXmKPExsVy+t9jQd1nLKKhBpeOM1qsfP+X0WLZ/+9M FktvVVs8mLeNzaLhxSRWiwmXtzNanF12kM3i/6PXrBZHfxdYbHp8jdXi8q45bBZH/vczWnx6 8J/Z4smZmYwWH+5fZLY4vjbcQcBjdsNFFo+/z6+zeOycdZfd4861PWwem5fUe9x4tZDJ4++s /SwefVtWMXpsvzaP2ePzJrkArqgGRpuM1MSU1CKF1Lzk/JTMvHRbJe/geOd4UzMDQ11DSwtz JYW8xNxUWyUXnwBdt8wcoE+UFMoSc0qBQgGJxcVK+naYJoSGuOlawDRG6PqGBMH1GBmggYQ1 jBkbWzcwFdzgqtj98QZ7A+Mr9i5GTg4JAROJCUteQtliEhfurWfrYuTiEBKYzihxcNIRVgjn AaPEw1fLGEGqeAW0JK7NXQ/WwSKgKvH67kqwOJuAjsT2b8eZQGxRgTCJiTcfs0LUC0r8mHyP BcQWEfCT+PPrOwvIUGaB5awST+atAWsWBko0n93FDLHtMqPEve5lQA4HB6dAsMSTdWogJrOA usSUKbkg5cwC8hKb17xlnsAoMAvJilkIVbOQVC1gZF7FKJpakFxQnJSea6RXnJhbXJqXrpec n7uJEZxYnknvYFzVYHGIUYCDUYmH98dukVAh1sSy4srcQ4wSHMxKIrwrHwOFeFMSK6tSi/Lj i0pzUosPMZoCA2Ais5Rocj4w6eWVxBsam5gZWRqZG1oYGZsrifMq2beFCAmkJ5akZqemFqQW wfQxcXBKNTBOyJjS6nWmaW/6+otRRb+kXSdmu7BdiRVd8eHE7DQhrbndJw/3FFWxCL9yqfWX 4op1+MTDspNtRuI3tTsiHjr7Ot/OZ+zepW7M+iv/kI9is9uZS7+73fiW7vrxderVv+0SNhd5 10Uv+j19p8GCbQKeTu+aZgn0arK5uZ1Pz/yYX7hwns69niYlluKMREMt5qLiRADe5jadQgMA AA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 03/23/2015 06:59 AM, Doug Anderson wrote: > Alim, > > On Sun, Mar 22, 2015 at 5:16 AM, Alim Akhtar wrote: >>> case MMC_POWER_OFF: >>> - /* Turn clock off before power goes down */ >>> - dw_mci_setup_bus(slot, false); >>> + /* Turn clock off before power goes down; only if powered */ >>> + if (slot->host->vqmmc_enabled) >>> + dw_mci_setup_bus(slot, false); >>> >> vqmmc_enabled is always _true_ when entering MMC_POWER_OFF case..right? >> Is this done for extra protection? Or do you have a case where vqmmc >> is OFF and driver still calls dw_mci_setup_bus from here? > > Hmm. I know I got it into the debugger in at least one reboot case > where it was failing to turn the clock off. I thought I confirmed it > was the core trying to call MMC_POWER_OFF when the power was already > off, but now I'm less certain. I looked back at my debug session and > I don't see where I got that evidence. :-/ Certainly if I put a > printout here right now I can't see my code making a difference. I'm not sure this is really needs...and i can't find any error case.. Best Regards, Jaehoon Chung > > Unfortunately the crash was a very rare one, so I may have to go back > to the drawing board here... > > -Doug >