From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753655AbbC0Iqi (ORCPT ); Fri, 27 Mar 2015 04:46:38 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:20318 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753246AbbC0Iqa (ORCPT ); Fri, 27 Mar 2015 04:46:30 -0400 X-AuditID: cbfee68f-f791c6d000004834-8f-551518c69f89 Message-id: <551518C6.9030804@samsung.com> Date: Fri, 27 Mar 2015 17:45:58 +0900 From: Beomho Seo User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-version: 1.0 To: Lee Jones Cc: Krzysztof Kozlowski , Sebastian Reichel , Jaewon Kim , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux-input@vger.kernel.org, Inki Dae , SangBae Lee , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Chanwoo Choi , Dmitry Torokhov Subject: Re: [PATCH v7 2/5] power: max77843_charger: Add Max77843 charger device driver References: <54FCEABE.9000007@samsung.com> <54FD880E.30903@samsung.com> <1425903199.13415.9.camel@AMDC1943> <54FEF541.6000305@samsung.com> <551119DE.2070402@samsung.com> <551408E0.3060901@samsung.com> <20150326135412.GJ5951@x1> <55149AFC.1080009@samsung.com> <20150327075758.GB15988@x1> In-reply-to: <20150327075758.GB15988@x1> Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrIIsWRmVeSWpSXmKPExsWyRsSkRPeYhGiowdM/GhbXvzxntZh/5Byr xeFFLxgt+t8sZLU492olo8Wk+xNYLHY0HGG1eP3C0OL+16OMFjc/fWO1uLxrDpvF594jjBZL r19kspgwfS2LReveI+wWxz8dZLE4vbvEQdBjzbw1jB6X+3qZPHbOusvusXL5FzaPTas62Tzu XNvD5tG3ZRWjx+dNcgEcUVw2Kak5mWWpRfp2CVwZP2+uYCk4qV/xtPE5UwPjVPUuRk4OCQET iY3Xb7JD2GISF+6tZ+ti5OIQEljKKPHryXY2mKKVHVeZIBLTGSW+frvCDuE8YJSY1X8NrIpX QEvi9PZFLCA2i4CqxNYfH5lAbDYBTYn3U64AxTk4RAUiJG5f5oQoF5T4MfkeWFhEQEXi3Btz kJHMAldZJFZt+Aw2UlggUmLitutQF21hljgyZxJYglNAQ6LjwAN2kGZmAXWJKVNyQcLMAvIS m9e8ZQaplxBYyyGxf+I0Noh7BCS+TT4EtkxCQFZi0wFmiMckJQ6uuMEygVFsFpKTZiFMnYVk 6gJG5lWMoqkFyQXFSelFxnrFibnFpXnpesn5uZsYgTF/+t+z/h2Mdw9YH2IU4GBU4uH9sVsk VIg1say4MvcQoynQEROZpUST84GJJa8k3tDYzMjC1MTU2Mjc0kxJnHeh1M9gIYH0xJLU7NTU gtSi+KLSnNTiQ4xMHJxSDYyRX43tEw3E3OYW7YnY2qQgpfllaoPdK6/1/sc6f4eXeX1e5rJ9 WtuT2xbiEQ/+y58XOvRQzaUkJEeHlUk72TnUdXN0Sqi7oUFeTeDhE/2mXjGrdmlsviXIfGSa rOFhkcaDDtkXjDTe2e8+9vEG3/oA68PJ0RVrLErlp4twKmzikdk289PJfCWW4oxEQy3mouJE AINXX+P0AgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrNKsWRmVeSWpSXmKPExsVy+t9jQd1jEqKhBh9Wy1hc//Kc1WL+kXOs FocXvWC06H+zkNXi3KuVjBaT7k9gsdjRcITV4vULQ4v7X48yWtz89I3V4vKuOWwWn3uPMFos vX6RyWLC9LUsFq17j7BbHP90kMXi9O4SB0GPNfPWMHpc7utl8tg56y67x8rlX9g8Nq3qZPO4 c20Pm0ffllWMHp83yQVwRDUw2mSkJqakFimk5iXnp2TmpdsqeQfHO8ebmhkY6hpaWpgrKeQl 5qbaKrn4BOi6ZeYAvaGkUJaYUwoUCkgsLlbSt8M0ITTETdcCpjFC1zckCK7HyAANJKxhzPh5 cwVLwUn9iqeNz5kaGKeqdzFyckgImEis7LjKBGGLSVy4t56ti5GLQ0hgOqPE129X2CGcB4wS s/qvsYFU8QpoSZzevogFxGYRUJXY+uMjWDebgKbE+ylXgOIcHKICERK3L3NClAtK/Jh8Dyws IqAice6NOchIZoGrLBKrNnwGGyksECkxcdt1qMVbmCWOzJkEluAU0JDoOPCAHaSZWUBdYsqU XJAws4C8xOY1b5knMArMQrJiFkLVLCRVCxiZVzGKphYkFxQnpeca6hUn5haX5qXrJefnbmIE J5RnUjsYVzZYHGIU4GBU4uH9sVskVIg1say4MvcQowQHs5II78rHQCHelMTKqtSi/Pii0pzU 4kOMpkD/T2SWEk3OBya7vJJ4Q2MTMyNLI3NDCyNjcyVxXiX7thAhgfTEktTs1NSC1CKYPiYO TqkGxjnb7DeGRNz/EbFoivqTH0tct3YxWcyz6IxguyK77+yWrjNBF6csf7f5XW578uVIRin9 s4XGMi7TC4+nH64/9lD58uLGkOZow4+iN5hK3l2cspm37LCCSW5FSuH74HcvfD/MX8LL+HqX 2f+0zjuPkp8Wv9Q/sEHowf+8k1vt5FZerzHQXhGQNFGJpTgj0VCLuag4EQBf1er9PgMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/27/2015 04:57 PM, Lee Jones wrote: > On Fri, 27 Mar 2015, Beomho Seo wrote: >> On 03/26/2015 10:54 PM, Lee Jones wrote: >>> On Thu, 26 Mar 2015, Beomho Seo wrote: >>>> On 03/24/2015 05:38 PM, Krzysztof Kozlowski wrote: >>>>> 2015-03-24 9:01 GMT+01:00 Beomho Seo : >>>>>> On 03/10/2015 10:44 PM, Beomho Seo wrote: >>>>>>> On 03/09/2015 09:13 PM, Krzysztof Kozlowski wrote: >>>>>>>> On pon, 2015-03-09 at 20:46 +0900, Beomho Seo wrote: >>>>>>>>> On 03/09/2015 08:02 PM, Krzysztof Kozlowski wrote: >>>>>>>>>> 2015-03-09 1:35 GMT+01:00 Beomho Seo : >>>>>>>>>>> On 03/08/2015 05:13 AM, Sebastian Reichel wrote: >>>>>>>>>>>> On Mon, Mar 02, 2015 at 07:10:35PM +0900, Jaewon Kim wrote: >>>>>>>>>>>>> From: Beomho Seo >>>>>>>>>>>>> >>>>>>>>>>>>> This patch adds device driver of max77843 charger. This driver provide >>>>>>>>>>>>> initialize each charging mode(e.g. fast charge, top-off mode and constant >>>>>>>>>>>>> charging mode so on.). Additionally, control charging paramters to use >>>>>>>>>>>>> i2c interface. >>>>>>>>>>>>> >>>>>>>>>>>>> Cc: Sebastian Reichel >>>>>>>>>>>>> Signed-off-by: Beomho Seo >>>>>>>>>>>> >>>>>>>>>>>> Reviewed-By: Sebastian Reichel >>>>>>>>>>>> >>>>>>>>>>>> I can't take it as is, since it depends on the private header file >>>>>>>>>>>> of PATCHv1. >>>>>>>>>>>> >>>>>>>>>>>> -- Sebastian >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> This patch reviewed by Sebastian. >>>>>>>>>>> Could you Please merge that your git tree ? >>>>>>>>>> >>>>>>>>>> Hi, >>>>>>>>>> >>>>>>>>>> ... and again we are adding a new driver for very similar chipset to >>>>>>>>>> already supported. I looked at spec and the charger's registers are >>>>>>>>>> almost the same as for max77693. Their layout and addresses are the >>>>>>>>>> same. I see some minor differences, probably the most important would >>>>>>>>>> be different values current (fast-charge, top-off). But still 90% of >>>>>>>>>> registers are the same... Do we really have to add new driver? >>>>>>>>>> >>>>>>>>>> Best regards, >>>>>>>>>> Krzysztof >>>>>>>>>> >>>>>>>>> >>>>>>>>> Hi, >>>>>>>>> >>>>>>>>> Thank you for your comment. As you say, both chip set are similar. >>>>>>>>> But new driver need for support max77843. It is support different below >>>>>>>>> - Provide Battery presence information. >>>>>>>> >>>>>>>> Another set of power supply properties could be added for that chip. >>>>>>>> This way the get_property() function would be the same but actually the >>>>>>>> POWER_SUPPLY_PROP_PRESENT won't be called for max77693. >>>>>>>> >>>>>>>>> - Can OTG FET control. >>>>>>>> >>>>>>>> Where the OTG FET feature is it enabled in your driver? I couldn't find >>>>>>>> it. >>>>>>>> >>>>>>> >>>>>>> Sorry. This driver don't control OTG FET feature. >>>>>>> >>>>>>>>> - Bigger Fast charge current, Top Off current Threshold selection. >>>>>>>>> - Various and bigger OTG current limitation. >>>>>>>>> - Bigger primary charger termination voltage setting. >>>>>>>>> - Different maximum input current limit selection(Different step). >>>>>>>> >>>>>>>> Yes, I mentioned some of these differences (the Fast/top-off >>>>>>>> differences). These are differences in values so it does not require new >>>>>>>> driver. There is need to develop new driver just to support different >>>>>>>> current (3.0 A instead of 2.1 A) or voltage threshold. >>>>>>>> >>>>>>> >>>>>>> They are different charging current, OTG current limitation, top off current, >>>>>>> charging limitation value. In case OTG current limitation different not >>>>>>> limitation value but using register bit(max77843 use[7:6] max77693 use[7] >>>>>>> bit only). Even if this driver not support all feature, some register >>>>>>> different with max77693(support value, use register bit). >>>>>>> >>>>>>> If this driver will combined with max77693 may even be beneficial for >>>>>>> new Maxim driver. But the present, this driver is related with >>>>>>> max77843 core driver and max77843-regulator. So I hope this driver >>>>>>> merge first. And then will extend two driver(max77843 charger and max77693 charger). >>>>> >>>>> I still prefer merging common drivers into one instead of creating >>>>> some more of them. >>>>> However I understand your point and I am not entirely opposed against. >>>>> Especially that you invested quite a bit of time for developing this >>>>> and my feedback was quite late. To summarize I am fine with your >>>>> approach. >>>>> >>>>> Best regards, >>>>> Krzysztof >>>>> >>>> >>>> Dear Lee Jones, >>>> >>>> Could you please merge that your git tree ? >>> >>> Sorry, I'm lost. Why am I taking this though the MFD tree? What >>> patches are left? Where are they going? Am I taking any other >>> patches? >>> >> >> Max77843 charger driver is max77843 mfd core dependency. > > What kind of dependancy? Runtime or build? Where is the patch that > it depends on? Is it in -next for in Mainline already? > Build. Max77843 charger driver use max77843-private.h. It is in for-mfd-next branch. c7f585f mfd: max77843: Add max77843 MFD driver core driver >> If you think this patch will suitable for battery tree(or other tree), >> I would like request for merge battery tree. > > If this patch has no build dependencies on patches which are in -next, > but not in Mainline then it will have to go in via the same tree that > the dependencies were applied to. If the dependencies are already in > Mainline, or they are not build-deps, then it should go in via the > correct tree, which I believe is Sebastian's tree. > >> Also, I will send again this patch and device tree binding document. > > Either way you should do that. Mark them as RESEND instead of PATCH > and apply all of the Acks you have accumulated so far. > I will send new version because binding document have been modified. As your comment patch will be mark. Best regards Beomho Seo