From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S964796AbbC0PPc (ORCPT <rfc822;w@1wt.eu>);
	Fri, 27 Mar 2015 11:15:32 -0400
Received: from bhuna.collabora.co.uk ([93.93.135.160]:39485 "EHLO
	bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S964772AbbC0PP2 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 27 Mar 2015 11:15:28 -0400
Message-ID: <5515740B.7090200@collabora.co.uk>
Date: Fri, 27 Mar 2015 16:15:23 +0100
From: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.2.0
MIME-Version: 1.0
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>
CC: Kukjin Kim <kgene@kernel.org>, Doug Anderson <dianders@chromium.org>,
        Olof Johansson <olof@lixom.net>,
        Abhilash Kesavan <kesavan.abhilash@gmail.com>,
        Kevin Hilman <khilman@linaro.org>,
        Tyler Baker <tyler.baker@linaro.org>,
        Steve Capper <steve.capper@linaro.org>,
        Amit Kucheria <amit.kucheria@linaro.org>,
        linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 2/2] ARM: EXYNOS: Make sure that the Exynos5420 MDMA0
 clock is enabled during suspend
References: <1427466097-7287-1-git-send-email-javier.martinez@collabora.co.uk>	<1427466097-7287-3-git-send-email-javier.martinez@collabora.co.uk> <CAJKOXPcak1RrvpjQNhVpd+oQODMNvbNhV0TmzO6VNsjcdqxfvw@mail.gmail.com>
In-Reply-To: <CAJKOXPcak1RrvpjQNhVpd+oQODMNvbNhV0TmzO6VNsjcdqxfvw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello Krzysztof,

Thanks a lot for your feedback.

On 03/27/2015 03:38 PM, Krzysztof Kozlowski wrote:
> 2015-03-27 15:21 GMT+01:00 Javier Martinez Canillas
> <javier.martinez@collabora.co.uk>:
>> Commit ae43b3289186 ("ARM: 8202/1: dmaengine: pl330: Add runtime Power
>> Management support v12") added pm support for the pl330 dma driver but
>> it makes the clock for the Exynos5420 MDMA0 DMA controller to be gated
>> during suspend and this clock needs to remain enabled in order to make
>> the system resume from a system suspend state.
>>
>> To make sure that the clock is enabled during suspend, enable it prior
>> to entering a suspend state and disable it once the system has resumed.
>>
>> Thanks to Abhilash Kesavan for figuring out that this was the issue.
>>
>> Fixes: ae43b32 ("ARM: 8202/1: dmaengine: pl330: Add runtime Power Management support v12")
>> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> 
> Hmmm... isn't a real problem elsewhere - like some clock hierarchy is
> wrong or incomplete? This rather looks like workaround for the
> problem.
>

That's a very good question, that's why I sent it as an RFC. I didn't find
anything relevant in the manual but I could certainly be missing something.

>>
>> @@ -516,6 +528,9 @@ static void exynos5420_pm_resume(void)
>>  {
>>         unsigned long tmp;
>>
>> +       if (!IS_ERR_OR_NULL(clk))
>> +               clk_disable_unprepare(clk);
>> +
> 
> Missing clk_put()
>

Yes, Sylwester already pointed it out. Sorry for missing that.
 
> Best regards,
> Krzysztof
> 

Best regards,
Javier