From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932193AbbC0QfP (ORCPT ); Fri, 27 Mar 2015 12:35:15 -0400 Received: from www.sr71.net ([198.145.64.142]:55319 "EHLO blackbird.sr71.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932111AbbC0QfM (ORCPT ); Fri, 27 Mar 2015 12:35:12 -0400 Message-ID: <551586BE.1040501@sr71.net> Date: Fri, 27 Mar 2015 09:35:10 -0700 From: Dave Hansen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Borislav Petkov CC: linux-kernel@vger.kernel.org, x86@kernel.org, tglx@linutronix.de, dave.hansen@linux.intel.com, oleg@redhat.com, riel@redhat.com, sbsiddha@gmail.com, luto@amacapital.net, mingo@redhat.com, hpa@zytor.com, fenghua.yu@intel.com Subject: Re: [PATCH 01/17] x86, fpu: wrap get_xsave_addr() to make it safer References: <20150326183327.64807530@viggo.jf.intel.com> <20150326183334.6D61EDA5@viggo.jf.intel.com> <20150327151555.GB5517@pd.tnic> In-Reply-To: <20150327151555.GB5517@pd.tnic> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/27/2015 08:15 AM, Borislav Petkov wrote: > I'm not sure we want to export this to modules... and MPX cannot be > built as a module either. So why export it? The thing I was wrapping (get_xsave_addr()) was EXPORT_SYMBOL_GPL(). I assumed that it was exported for good reason and that my wrapper should follow suit. I do expect this to get used by more things than just MPX going forward. But, I guess folks can just export it if and when they need it.