From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753280AbbC1NAp (ORCPT <rfc822;w@1wt.eu>);
	Sat, 28 Mar 2015 09:00:45 -0400
Received: from szxga02-in.huawei.com ([119.145.14.65]:5335 "EHLO
	szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752054AbbC1NAo (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 28 Mar 2015 09:00:44 -0400
Message-ID: <5516A5ED.4050108@huawei.com>
Date: Sat, 28 Mar 2015 21:00:29 +0800
From: Xie XiuQi <xiexiuqi@huawei.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: Steven Rostedt <rostedt@goodmis.org>, <linux-kernel@vger.kernel.org>
CC: Ingo Molnar <mingo@kernel.org>, Andrew Morton <akpm@linux-foundation.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
        Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
        Mauro Carvalho Chehab <m.chehab@samsung.com>
Subject: Re: [RFC][PATCH 09/10] v4l: Export enums used by tracepoints to user
 space
References: <20150327213704.857765144@goodmis.org> <20150327213814.576750758@goodmis.org>
In-Reply-To: <20150327213814.576750758@goodmis.org>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.177.17.191]
X-CFilter-Loop: Reflected
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2015/3/28 5:37, Steven Rostedt wrote:

>  #define show_field(field)						\
> -	__print_symbolic(field,						\
> -		{ V4L2_FIELD_ANY,		"ANY" },		\
> -		{ V4L2_FIELD_NONE,		"NONE" },		\
> -		{ V4L2_FIELD_TOP,		"TOP" },		\
> -		{ V4L2_FIELD_BOTTOM,		"BOTTOM" },		\
> -		{ V4L2_FIELD_INTERLACED,	"INTERLACED" },		\
> -		{ V4L2_FIELD_SEQ_TB,		"SEQ_TB" },		\
> -		{ V4L2_FIELD_SEQ_BT,		"SEQ_BT" },		\
> -		{ V4L2_FIELD_ALTERNATE,		"ALTERNATE" },		\
> -		{ V4L2_FIELD_INTERLACED_TB,	"INTERLACED_TB" },      \
> -		{ V4L2_FIELD_INTERLACED_BT,	"INTERLACED_BT" })
> +	__print_symbolic(field, SHOW_FIELD

Hi Steve,

It is missing a right bracket ')' here.

Thanks,
	Xie XiuQi

> +
> +#define SHOW_FIELD							\
> +	EM( V4L2_FIELD_ANY,		"ANY" )				\
> +	EM( V4L2_FIELD_NONE,		"NONE" )			\
> +	EM( V4L2_FIELD_TOP,		"TOP" )				\