Re: [RFC][PATCH 00/10] tracing: Use TRACE_DEFINE_ENUM() to show enum values

Masami Hiramatsu
2015-04-01T07:26:04Z

(2015/03/31 22:26), Steven Rostedt wrote:
> On Tue, 31 Mar 2015 16:36:51 +0900
> Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> wrote:
>
>>> Instead of adding an enum mapping file, I could add a way to look at
>>> all the events in the system that defined a mapping, and do a
>>> "s/ENUM_NAME/ENUM_VALUE/g" do the saved print formats? I'm not sure how
>>> much we want to do that in the kernel though.
>>
>> No, it's not what I expected...
>
> Actually, I'm going to play with this idea and see how crazy it is or
> isn't. Converting the ENUMS in TP_printk() might actually be doable.
>
> I'll write up some code and we can see if it seems sane or not. OK?

Yeah, I see. Thanks.

>> What I thought was expanding __print_symbolic() macro in TP_printk
>> with a special hash string(start with #), and when showing it via
>> event/format, replace the hash string with the strings generated
>> by the map of symbols. This will introduce a small overhead to show
>> the format as a side effect.
>>
>> Actually I even have not tried, so it's just an idea yet.
>>
>
> If you can figure something out, please let me know!

OK, I'll try to find the other way.

Thank you!

>
> Thanks,
>
> -- Steve
>

--
Masami HIRAMATSU
Linux Technology Research Center, System Productivity Research Dept.
Center for Technology Innovation - Systems Engineering
Hitachi, Ltd., Research & Development Group
E-mail: masami.hiramatsu.pt@hitachi.com