From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752387AbbC1VwI (ORCPT ); Sat, 28 Mar 2015 17:52:08 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:55536 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752013AbbC1VwF (ORCPT ); Sat, 28 Mar 2015 17:52:05 -0400 Message-ID: <55172210.4070900@ti.com> Date: Sat, 28 Mar 2015 23:50:08 +0200 From: Peter Ujfalusi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Stephen Warren CC: , , , , , , Lee Jones Subject: Re: [PATCH 3/5] dmaengine: bcm2835-dma: Fix memory leak when stopping a running transfer References: <1427456155-28990-1-git-send-email-peter.ujfalusi@ti.com> <1427456155-28990-4-git-send-email-peter.ujfalusi@ti.com> <551626A5.3080509@wwwdotorg.org> In-Reply-To: <551626A5.3080509@wwwdotorg.org> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks, On 03/28/2015 05:57 AM, Stephen Warren wrote: > On 03/27/2015 05:35 AM, Peter Ujfalusi wrote: >> The vd->node is removed from the lists when the transfer started so the >> vchan_get_all_descriptors() will not find it. This results memory leak. > > Acked-by: Stephen Warren > (I'm just assuming the explanation makes sense and is correct; more of a > not-a-NAK so it doesn't look like a lack of response!) I can not debug the bcm2835-dma driver, but the exact same pattern existed in edma and omap-dma driver and they both leaked the edesc in a same predictable fashion. I just checked the virt-dma users and sent the fixes for the ones which had the same flow of events. -- Péter