From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752723AbbC1WVz (ORCPT ); Sat, 28 Mar 2015 18:21:55 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:44363 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751638AbbC1WVx (ORCPT ); Sat, 28 Mar 2015 18:21:53 -0400 Message-ID: <55172939.4070100@roeck-us.net> Date: Sat, 28 Mar 2015 15:20:41 -0700 From: Guenter Roeck User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: =?UTF-8?B?UGFsaSBSb2jDoXI=?= , Steven Honeyman CC: Paul Bolle , Arnd Bergmann , Greg Kroah-Hartman , Jean Delvare , Valdis Kletnieks , Jochen Eisinger , Gabriele Mazzotta , linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org Subject: Re: [PATCH 2/2] hwmon: Allow to compile dell-smm-hwmon driver without /proc/i8k References: <1427538255-10860-1-git-send-email-pali.rohar@gmail.com> <1427540660.2334.14.camel@x220> <201503282300.48749@pali> In-Reply-To: <201503282300.48749@pali> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-CTCH-PVer: 0000001 X-CTCH-Spam: Unknown X-CTCH-VOD: Unknown X-CTCH-Flags: 0 X-CTCH-RefID: str=0001.0A020202.55172980.003B,ss=1,re=0.001,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 X-CTCH-Score: 0.001 X-CTCH-ScoreCust: 0.000 X-CTCH-Rules: C_4847, X-CTCH-SenderID: linux@roeck-us.net X-CTCH-SenderID-Flags: 0 X-CTCH-SenderID-TotalMessages: 2 X-CTCH-SenderID-TotalSpam: 0 X-CTCH-SenderID-TotalSuspected: 0 X-CTCH-SenderID-TotalConfirmed: 0 X-CTCH-SenderID-TotalBulk: 0 X-CTCH-SenderID-TotalVirus: 0 X-CTCH-SenderID-TotalRecipients: 0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: mailgid no entry from get_relayhosts_entry X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/28/2015 03:00 PM, Pali Rohár wrote: > On Saturday 28 March 2015 13:54:51 Steven Honeyman wrote: >> On 28 March 2015 at 11:04, Paul Bolle > wrote: >>> On Sat, 2015-03-28 at 11:24 +0100, Pali Rohár wrote: >>>> --- a/drivers/hwmon/Kconfig >>>> +++ b/drivers/hwmon/Kconfig >>>> @@ -1703,6 +1703,17 @@ config SENSORS_ULTRA45 >>>> >>>> This driver provides support for the Ultra45 >>>> workstation environmental sensors. >>>> >>>> +config SENSORS_DELL_SMM >>>> + tristate "Dell laptop SMM BIOS hwmon driver" >>>> + depends ON X86 >>> >>> How did this past your testing? >>> >>>> + ---help--- >>>> + This hwmon driver adds support for reporting >>>> temperature of different + sensors and controls the >>>> fans on Dell laptops via System Management + Mode >>>> provided by Dell BIOS. >>>> + >>>> + When option I8K is also enabled this driver >>>> provides legacy /proc/i8k + userspace interface for >>>> i8kutils package. >>>> + >> >> It's working OK for me (after fixing the mistake pointed out >> above). >> >> [Latitude e6540] >> ----- >> coretemp-isa-0000 >> Adapter: ISA adapter >> Physical id 0: +53.0°C (high = +84.0°C, crit = +100.0°C) >> Core 0: +51.0°C (high = +84.0°C, crit = +100.0°C) >> Core 1: +53.0°C (high = +84.0°C, crit = +100.0°C) >> >> i8k-virtual-0 >> Adapter: Virtual device >> Processor Fan: 3171 RPM >> CPU: +52.0°C >> Ambient: +46.0°C >> SODIMM: +40.0°C >> ----- >> >> Ambient and SODIMM look swapped - but it's probably just >> another Dell error. I really need to look at getting coreboot >> on this thing. >> > > Both patches do not change any code. So there should not be any > type swapped with or without my patch. > > Cpu type is requested via SMM in same way as it is doing old DOS > executable. So there can be maybe problem in DELL SMM handler too > or maybe just I did not understand correctly assembler dump of > DOS executable... > >> On 28 March 2015 at 10:24, Pali Rohár >> wrote: ... >> >>> config I8K >>> >>> - tristate "Dell laptop support" >>> - select HWMON >>> + bool "Dell i8k legacy laptop support" >>> + select SENSORS_DELL_SMM >> >> ... >> >>> +config SENSORS_DELL_SMM >>> + tristate "Dell laptop SMM BIOS hwmon driver" >> >> The only change I'd suggest is not to change the tristate to >> bool for I8K. Forcing that to bool means that >> SENSORS_DELL_SMM can't be compiled as a module if the user >> wishes to keep i8k hanging around "just in case". It'll >> probably annoy distro kernel packagers too. >> >> >> Thanks, >> Steven > > My idea was: > > SENSORS_DELL_SMM enable/disable compilation of kernel driver > (ether statically link into kernel image or as external module) > > CONFIG_I8K just enable /proc/i8k code in SENSORS_DELL_SMM -- no > additional driver, just boolean switch which has effect only iff > SENSORS_DELL_SMM is Y or M > Maybe that is the plan, but it is not what is happening. I8K selects SENSORS_DELL_SMM, so a boolean I8K forces SENSORS_DELL_SMM to be built into the kernel. What you suggest would work if I8K would depend on SENSORS_DELL_SMM, but then the symbols would not be backward-compatible. Guenter