From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752725AbbC2XVJ (ORCPT <rfc822;w@1wt.eu>);
	Sun, 29 Mar 2015 19:21:09 -0400
Received: from mail-la0-f46.google.com ([209.85.215.46]:33079 "EHLO
	mail-la0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752647AbbC2XVG (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sun, 29 Mar 2015 19:21:06 -0400
Message-ID: <551888DE.1050003@gmail.com>
Date: Mon, 30 Mar 2015 01:21:02 +0200
From: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: Joe Perches <joe@perches.com>
CC: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 10/11] staging: rtl8192e: Decrease nesting of rtllib_rx_auth_resp()
References: <1427668867-10906-1-git-send-email-mateusz.kulikowski@gmail.com>	 <1427668867-10906-11-git-send-email-mateusz.kulikowski@gmail.com> <1427670839.2715.44.camel@perches.com>
In-Reply-To: <1427670839.2715.44.camel@perches.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Joe, 

Thanks for reviewing my patches.

On 30.03.2015 01:13, Joe Perches wrote:
> On Mon, 2015-03-30 at 00:41 +0200, Mateusz Kulikowski wrote:
>> Return from rtllib_rx_auth_resp() if auth_parse() fails.
> 
> Hello Mateusz.  Here are some trivial notes.
> 
>> diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rtl8192e/rtllib_softmac.c
> []
>> +		/* Dummy wirless mode setting to avoid
>> +		 * encryption issue */
> 
> Please use the typical networking comment style
> (and correct the typo too)
> 
> 		/* Dummy wireless mode setting to avoid
> 		 * encryption issue
> 		 */

It was like that already - is it ok with you if I fix all the comments (in whole rtl8192e) in separate patch 
(I can add it as #12 to v2) ?

> 
>> +		if (bSupportNmode) {
>> +			ieee->SetWirelessMode(ieee->dev,
>> +			   ieee->current_network.mode);
>> +		} else {
>> +			/*TODO*/
>> +			ieee->SetWirelessMode(ieee->dev,
>> +					      IEEE_G);
> 
> Many of these multiple line statements can be single line.

I wanted to split change of logic and re-indentation;
If you insist - I can merge patches #10 and #11 (#11 does what you ask for)


Regards,
Mateusz