From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752742AbbC3CtH (ORCPT ); Sun, 29 Mar 2015 22:49:07 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:40144 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751936AbbC3CtE (ORCPT ); Sun, 29 Mar 2015 22:49:04 -0400 Message-ID: <5518B985.5020906@oracle.com> Date: Sun, 29 Mar 2015 20:48:37 -0600 From: David Ahern User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Mike Galbraith CC: peterz@infradead.org, mingo@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH] sched: Add cpu based entries to debugfs References: <1427681613-98163-1-git-send-email-david.ahern@oracle.com> <1427682744.3185.16.camel@gmx.de> In-Reply-To: <1427682744.3185.16.camel@gmx.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/29/15 8:32 PM, Mike Galbraith wrote: > On Sun, 2015-03-29 at 22:13 -0400, David Ahern wrote: > >> diff --git a/kernel/sched/core.c b/kernel/sched/core.c >> index 62671f53202a..b4d8d0c8260e 100644 >> --- a/kernel/sched/core.c >> +++ b/kernel/sched/core.c >> @@ -268,12 +268,173 @@ static const struct file_operations sched_feat_fops = { >> .release = single_release, >> }; >> >> +static const char * const sd_flag_names[] = { >> + "load-balance", >> + "new-idle", >> + "exec", >> + "fork", >> + "wake", >> + "affine", >> + "", >> + "cpu-capacity", >> + "power-domain", >> + "share-pkg-resources", >> + "serialize", >> + "asym-packing", >> + "prefer-sibling", >> + "overlap", >> + "numa", >> + "", >> +}; > > That's wrong with the names readers will want to grep for? I just found lower-case easier on the eyes. I could change this list to correspond to the SD_XXXXX defines. Certainly something that more programmatically correlates the macros (bit positions) and the names would be better. David