From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753831AbbC3TlR (ORCPT ); Mon, 30 Mar 2015 15:41:17 -0400 Received: from mail-ig0-f173.google.com ([209.85.213.173]:37581 "EHLO mail-ig0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753526AbbC3TlO (ORCPT ); Mon, 30 Mar 2015 15:41:14 -0400 Message-ID: <5519A6D8.9060806@gmail.com> Date: Mon, 30 Mar 2015 13:41:12 -0600 From: David Ahern User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Peter Zijlstra CC: Stephane Eranian , Arnaldo Carvalho de Melo , Thomas Gleixner , Jiri Olsa , Linus Torvalds , LKML , John Stultz , "H. Peter Anvin" , Andrew Morton , Ingo Molnar Subject: Re: [PATCH] perf, record: Add clockid parameter References: <20150327143201.GG21418@twins.programming.kicks-ass.net> <55158F25.9040100@gmail.com> <20150327172059.GK23123@twins.programming.kicks-ass.net> <551594DD.7050705@gmail.com> <20150327201534.GD6291@redhat.com> <20150327215942.GL23123@twins.programming.kicks-ass.net> <20150328075549.GG27490@worktop.programming.kicks-ass.net> <551986BC.3000409@gmail.com> <20150330193318.GF23123@twins.programming.kicks-ass.net> In-Reply-To: <20150330193318.GF23123@twins.programming.kicks-ass.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/30/15 1:33 PM, Peter Zijlstra wrote: > On Mon, Mar 30, 2015 at 11:24:12AM -0600, David Ahern wrote: >> This works but the result is not always intuitive as to why it failed. >> >> On a kernel that does not support the clock id you get: >> $ perf sched record -k mono -- sleep 1 >> Error: >> clockid not supported. >> >> And on a kernel that supports clockid but not for NMI: >> >> $ perf record -k realtime -a -- sleep 1 >> Error: >> clockid not supported. >> >> --> H/W counters so realtime is not allowed >> >> Same message though different root causes. > > Heh, ok I can fudge that :-) > What about having the kernel return 'not supported' error for the latter -- H/W counters with unsafe clock?