From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754649AbbC3UVV (ORCPT ); Mon, 30 Mar 2015 16:21:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36820 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753466AbbC3UU5 (ORCPT ); Mon, 30 Mar 2015 16:20:57 -0400 Message-ID: <5519B01B.9010007@redhat.com> Date: Mon, 30 Mar 2015 14:20:43 -0600 From: Eric Blake Organization: Red Hat, Inc. User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Eduardo Habkost , Michael Mueller CC: linux-s390@vger.kernel.org, kvm@vger.kernel.org, Gleb Natapov , linux-kernel@vger.kernel.org, Alexander Graf , qemu-devel@nongnu.org, Christian Borntraeger , Daniel Hansel , "Jason J. Herne" , Cornelia Huck , Paolo Bonzini , Andreas Faerber , Richard Henderson Subject: Re: [Qemu-devel] [PATCH v4 11/15] target-s390x: New QMP command query-cpu-model References: <1427725708-52100-1-git-send-email-mimu@linux.vnet.ibm.com> <1427725708-52100-12-git-send-email-mimu@linux.vnet.ibm.com> <20150330201721.GF7031@thinpad.lan.raisama.net> In-Reply-To: <20150330201721.GF7031@thinpad.lan.raisama.net> OpenPGP: url=http://people.redhat.com/eblake/eblake.gpg Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="PUFrRn8ATXBMOmSO0Gtrhd6DNqTH0P3Ai" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --PUFrRn8ATXBMOmSO0Gtrhd6DNqTH0P3Ai Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/30/2015 02:17 PM, Eduardo Habkost wrote: > On Mon, Mar 30, 2015 at 04:28:24PM +0200, Michael Mueller wrote: >> This patch implements a new QMP request named 'query-cpu-model'. >> It returns the cpu model of cpu 0 and its backing accelerator. >> >> request: >> {"execute" : "query-cpu-model" } >> >> answer: >> {"return" : {"name": "2827-ga2", "accel": "kvm" }} >=20 > If you are returning information about an existing CPU, why not just > extend the output of "query-cpus"? >=20 > (Existing qmp_query_cpus() calls cpu_synchronize_state(), which may be > undesired. But in this case we could add an optional parameter to > disable the return of data that requires stopping the VCPU). And how would libvirt learn about the existence of that optional parameter? Without introspection, a new command is easier to query than learning about whether an optional parameter exists (then again, we're hoping to get introspection into 2.4, so it may be a moot question). --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --PUFrRn8ATXBMOmSO0Gtrhd6DNqTH0P3Ai Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVGbAcAAoJEKeha0olJ0Nqmq8H/RJhMMOgOc1Hmpr8sWm5yYEi r7eWCX9slWDowi5gDNzFRtEHlCT0H6BE8P6xECQO4felsGhmXwPtWGXQrs6HxVvH eeLMP63AC8avpPDYDu+FxeqBMVBG/Ae4SvEoIUM7WMh9fdwYHLaMrTgkNUDqDaXB pSNBv7DATe3Ws2Yy8Oz0NOuvbMg1ORAcZSMONFmwb4Q03NcQuNg+XHwj7lrxLQ1o DzXwoP/FLHbtbCCaZd86h72q1Wg2rxN1U3O3bjhXUlFiCharAK2/Auni1ongfrfo jtSxALU4+jBfx+fMyysEJyapHlVcWymhchmVaqLoIl/TSgMmoSJs7JnAuQhPEAc= =Zj0v -----END PGP SIGNATURE----- --PUFrRn8ATXBMOmSO0Gtrhd6DNqTH0P3Ai--