From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753062AbbC3VxS (ORCPT ); Mon, 30 Mar 2015 17:53:18 -0400 Received: from mail-ie0-f169.google.com ([209.85.223.169]:32823 "EHLO mail-ie0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752661AbbC3VxQ (ORCPT ); Mon, 30 Mar 2015 17:53:16 -0400 Message-ID: <5519C5C8.2020903@linaro.org> Date: Mon, 30 Mar 2015 15:53:12 -0600 From: Al Stone User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Hanjun Guo , Will Deacon , Catalin Marinas CC: linaro-acpi@lists.linaro.org, "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [Linaro-acpi] [PATCH 1/2] ARM64 / ACPI: Ignore the return error value of acpi_map_gic_cpu_interface() References: <1427458476-20140-1-git-send-email-hanjun.guo@linaro.org> In-Reply-To: <1427458476-20140-1-git-send-email-hanjun.guo@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/27/2015 06:14 AM, Hanjun Guo wrote: > MADT table scannig will stopped once it gets the errors > returned by the handler, which is acpi_map_gic_cpu_interface() > in for ARM64, so Ignore the return error value to search for > all enabled CPUs for SMP init. I think the comment should say something like: MADT scanning will stop when it gets an error from the handler, acpi_map_gic_cpu_interface(), on arm64. However, we need to find all of the enabled CPUs so that SMP initialization can work properly. So, if an error occurs in this case, ignore it for now so that we can find all of the enabled CPUs. Is that what you meant, Hanjun? > Signed-off-by: Hanjun Guo > --- > arch/arm64/kernel/acpi.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/kernel/acpi.c b/arch/arm64/kernel/acpi.c > index 07649e4..c263cba 100644 > --- a/arch/arm64/kernel/acpi.c > +++ b/arch/arm64/kernel/acpi.c > @@ -181,7 +181,8 @@ acpi_parse_gic_cpu_interface(struct acpi_subtable_header *header, > return -EINVAL; > > acpi_table_print_madt_entry(header); > - return acpi_map_gic_cpu_interface(processor); > + acpi_map_gic_cpu_interface(processor); > + return 0; > } > > /* Parse GIC cpu interface entries in MADT for SMP init */ > -- ciao, al ----------------------------------- Al Stone Software Engineer Linaro Enterprise Group al.stone@linaro.org -----------------------------------