From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753846AbbC3Xh5 (ORCPT ); Mon, 30 Mar 2015 19:37:57 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:41235 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753362AbbC3Xhy (ORCPT ); Mon, 30 Mar 2015 19:37:54 -0400 X-AuditID: cbfee690-f79ab6d0000046f7-c3-5519de4f2dca Message-id: <5519DE4F.3080608@samsung.com> Date: Tue, 31 Mar 2015 08:37:51 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 MIME-version: 1.0 To: Krzysztof Kozlowski Cc: Kukjin Kim , Alessandro Zummo , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, rtc-linux@googlegroups.com, Alexandre Belloni , Kyungmin Park Subject: Re: [PATCH 1/2] drivers/rtc/rtc-s3c.c: Integrate Exynos3250 into S3C6410 References: <1427728773-29065-1-git-send-email-k.kozlowski@samsung.com> <1427728773-29065-2-git-send-email-k.kozlowski@samsung.com> In-reply-to: <1427728773-29065-2-git-send-email-k.kozlowski@samsung.com> Content-type: text/plain; charset=ISO-8859-1 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrJIsWRmVeSWpSXmKPExsWyRsSkUDfgnmSowR5+iyUXr7JbdFxbzGQx /8g5VovXLwwt+h+/ZrY42/SG3WLT42usFpd3zWGzmHF+H5PF/s4ORgcujyebLjJ67Jl4ks1j 06pONo/NS+o9+rasYvSYPu8nk8fnTXIB7FFcNimpOZllqUX6dglcGX/2ShSc5Kno2X2BrYFx KlcXIyeHhICJxPuFC9khbDGJC/fWs3UxcnEICSxllJh85wlTFyMHWNGT3XoQ8UWMEide3mCG cB4wSrx6soMRpJtXQEvi7fl7rCA2i4CqxOVNK9lAbDag+P4XN8BsUYEwiZXTr7BA1AtK/Jh8 D8wWETCUOLh7OxPIUGaBG0wSqy5OBBskLBAssWf2c7AFQgKtjBIrHgaA2JwCHhINz7aADWUW 0JHY3zoNypaX2LzmLdh1EgJf2SXO3XnABnGRgMS3yYdYIN6Rldh0gBniZUmJgytusExgFJuF 5KZZSMbOQjJ2ASPzKkbR1ILkguKk9CITveLE3OLSvHS95PzcTYzAGD3979mEHYz3DlgfYhTg YFTi4a24IxkqxJpYVlyZe4jRFOiKicxSosn5wESQVxJvaGxmZGFqYmpsZG5ppiTO+1rqZ7CQ QHpiSWp2ampBalF8UWlOavEhRiYOTqkGRh9BH14ppvPqubMZMi4cPHjdSnp3wrqNHAu9Oz8+ +Mt95NeTqFa+lf//Rk+4YvLhbO2TR+Ef5mXkvGN7783yo2Pm0r2sxy9ffuiz65uvs0eYVnLD u21rwz23WLvMKnfvOvzabo3o0hNuKXJhT0SPl7Sxt81ZFeV0R0Dw47JpT7aKcUgZGWUvm67E UpyRaKjFXFScCACqvEvDzAIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmphleLIzCtJLcpLzFFi42I5/e+xgK7/PclQgwdPTC2WXLzKbtFxbTGT xfwj51gtXr8wtOh//JrZ4mzTG3aLTY+vsVpc3jWHzWLG+X1MFvs7OxgduDyebLrI6LFn4kk2 j02rOtk8Ni+p9+jbsorRY/q8n0wenzfJBbBHNTDaZKQmpqQWKaTmJeenZOal2yp5B8c7x5ua GRjqGlpamCsp5CXmptoqufgE6Lpl5gCdp6RQlphTChQKSCwuVtK3wzQhNMRN1wKmMULXNyQI rsfIAA0krGHM+LNXouAkT0XP7gtsDYxTuboYOTgkBEwknuzW62LkBDLFJC7cW8/WxcjFISSw iFHixMsbzBDOA0aJV092MIJU8QpoSbw9f48VxGYRUJW4vGklG4jNBhTf/+IGmC0qECaxcvoV Foh6QYkfk++B2SIChhIHd29nAhnKLHCDSWLVxYlgg4QFgiX2zH4OtkBIoJVRYsXDABCbU8BD ouHZFrChzAI6Evtbp0HZ8hKb17xlnsAoMAvJjllIymYhKVvAyLyKUTS1ILmgOCk911CvODG3 uDQvXS85P3cTIzgFPJPawbiyweIQowAHoxIPr2O9RKgQa2JZcWXuIUYJDmYlEV7PrZKhQrwp iZVVqUX58UWlOanFhxhNgUEwkVlKNDkfmJ7ySuINjU3MjCyNzA0tjIzNlcR5lezbQoQE0hNL UrNTUwtSi2D6mDg4pRoY8x0nT7YTfpgRHvDs0+mbM3/e+dOxgSdAJH6i7E2Hm7u7TzacniEh /ObZh0uSl7NfaTMcmq+kmPo7c8a/rlvPqoNOHImddPB3adSebU+0NxX2zo/uPCs+6crjqcYc 735tt335fkZI3IN8zZyD3fJv/5754b1lc/ma/9N4Tbb/Xbbxh9yK06wtkYxKLMUZiYZazEXF iQCvX+uEFwMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/31/2015 12:19 AM, Krzysztof Kozlowski wrote: > There are now no differences between RTC on Exynos3250 and S3C6410. > Merge everything into one so duplicated code could be removed. > > Signed-off-by: Krzysztof Kozlowski > --- > drivers/rtc/rtc-s3c.c | 14 +------------- > 1 file changed, 1 insertion(+), 13 deletions(-) > > diff --git a/drivers/rtc/rtc-s3c.c b/drivers/rtc/rtc-s3c.c > index fb0c569765c6..5e162eaad277 100644 > --- a/drivers/rtc/rtc-s3c.c > +++ b/drivers/rtc/rtc-s3c.c > @@ -774,18 +774,6 @@ static struct s3c_rtc_data const s3c6410_rtc_data = { > .disable = s3c6410_rtc_disable, > }; > > -static struct s3c_rtc_data const exynos3250_rtc_data = { > - .max_user_freq = 32768, > - .needs_src_clk = true, > - .irq_handler = s3c6410_rtc_irq, > - .set_freq = s3c6410_rtc_setfreq, > - .enable_tick = s3c6410_rtc_enable_tick, > - .save_tick_cnt = s3c6410_rtc_save_tick_cnt, > - .restore_tick_cnt = s3c6410_rtc_restore_tick_cnt, > - .enable = s3c24xx_rtc_enable, > - .disable = s3c6410_rtc_disable, > -}; > - > static const struct of_device_id s3c_rtc_dt_match[] = { > { > .compatible = "samsung,s3c2410-rtc", > @@ -801,7 +789,7 @@ static const struct of_device_id s3c_rtc_dt_match[] = { > .data = (void *)&s3c6410_rtc_data, > }, { > .compatible = "samsung,exynos3250-rtc", > - .data = (void *)&exynos3250_rtc_data, > + .data = (void *)&s3c6410_rtc_data, > }, > { /* sentinel */ }, > }; > Looks good to me. Reviewd-by: Chanwoo Choi Thanks, Chanwoo Choi